Add validation for kube-scheduler configuration options #66799

noqcks · 2018-07-30T20:40:52Z

What this PR does / why we need it: This adds validation to the kube-scheduler so that we're not accepting bogus values to the kube-scheduler. As requested by @bsalamat in issue #66743

Which issue(s) this PR fixes:
Fixes #66743

Special notes for your reviewer:

Not sure if this validation is too heavy handed. Would love some feedback.
I started working on this before I realized @islinwb was also working on this same problem... [WIP]validate KubeSchedulerConfiguration and kube-scheduler flags #66787 I put this PR up anyways since I'm sure good code exists in both. I wasn't aware of the /assign command so didn't assign myself before starting work.
I didn't have time to work on adding validation to deprecated cli options. If the rest of this looks ok, I can finish that up.
I hope the location of IsValidSocketAddr is correct. Lmk if it isn't.

Release note:

Adding validation to kube-scheduler at the API level

noqcks · 2018-07-30T20:41:50Z

/assign @bsalamat

bsalamat

Thanks, @noqcks!
Some early comments.

bsalamat · 2018-07-30T21:06:34Z

staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go

+	var errs []string
+	ip, port, err := net.SplitHostPort(value)
+	if err != nil {
+		return append(errs, "must be a valid socket address format, (e.g. 0.0.0.0:10254)")


We should support IPv6 as well. So, you may want to augment your example.

bsalamat · 2018-07-30T21:06:59Z

staging/src/k8s.io/apimachinery/pkg/util/validation/validation_test.go

@@ -511,3 +511,28 @@ func TestIsFullyQualifiedName(t *testing.T) {
 		}
 	}
 }
+
+func TestIsValidSocketAddr(t *testing.T) {


Please add IPv6 examples as well.

bsalamat · 2018-07-30T21:19:06Z

pkg/apis/componentconfig/validation/validation_test.go

+	"time"
+)
+
+func TestValidateKubeSchedulerConfiguration(t *testing.T) {


Could you also add a test that the old style (deprecated) options still work?

I added some validations for deprecated options @bsalamat, but for some reason the function ListAlgorithmProviders was not returning the proper values I would expect "ClusterAutoscalerProvider | DefaultProvider" and was instead returning an empty string 🤔 .

I'm not sure exactly how I could get this to work. I was planning on using factory.ListAlgorithmProviders() in the Validate function. If you have any idea of a way I could get the list of valid algorithm providers I would love to understand. Thanks.

The use of different algorithm providers are not very important in my opinion. Actually, I think it is not used anymore (I am not sure though).

neolit123 · 2018-07-30T22:57:43Z

pkg/apis/componentconfig/validation/validation.go

@@ -0,0 +1,109 @@
+/*
+Copyright 2017 The Kubernetes Authors.


neolit123 · 2018-07-30T22:58:30Z

pkg/apis/componentconfig/validation/validation.go

+	if len(cc.SchedulerName) == 0 {
+		allErrs = append(allErrs, field.Required(field.NewPath("schedulerName"), ""))
+	}
+


the empty lines bellow {s can be removed here in ValidateKubeSchedulerConfiguration().

neolit123 · 2018-07-30T22:59:18Z

pkg/apis/componentconfig/validation/validation.go

+		allErrs = append(allErrs, field.Invalid(fldPath.Child("qps"), cc.QPS, "must be non-negative value"))
+	}
+	return allErrs
+


please, remove this empty line.

neolit123 · 2018-07-30T22:59:36Z

pkg/apis/componentconfig/validation/validation.go

+		allErrs = append(allErrs, field.Required(fldPath.Child("kubeConfigFile"), ""))
+	}
+	if cc.QPS < 0 {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("qps"), cc.QPS, "must be non-negative value"))


must be -> must be a

neolit123 · 2018-07-30T23:01:20Z

pkg/apis/componentconfig/validation/validation.go

+func ValidateSchedulerPolicySource(cc *componentconfig.SchedulerPolicySource, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+	if cc.File == nil && cc.ConfigMap == nil {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("file"), nil, "need to set atleast one of File or ConfigMap"))


need to set atleast one of File or ConfigMap
->
needs to set either File or ConfigMap
?

neolit123 · 2018-07-30T23:01:43Z

pkg/apis/componentconfig/validation/validation.go

+		allErrs = append(allErrs, field.Invalid(fldPath.Child("leaseDuration"), cc.LeaseDuration, "must be greater than or equal to 0"))
+	}
+	if cc.RenewDeadline.Duration < 0 {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("renewDeadline"), cc.LeaseDuration, "must be positive integer"))


a positive

neolit123 · 2018-07-30T23:02:07Z

pkg/apis/componentconfig/validation/validation.go

+		allErrs = append(allErrs, field.Invalid(fldPath.Child("renewDeadline"), cc.RenewDeadline, "RenewDeadline must be less than or equal to LeaseDuration"))
+	}
+	if cc.RetryPeriod.Duration <= 0 {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("retryPeriod"), cc.RetryPeriod, "must be positive integer"))


a positive

neolit123 · 2018-07-30T23:02:13Z

pkg/apis/componentconfig/validation/validation_test.go

@@ -0,0 +1,199 @@
+/*
+Copyright 2014 The Kubernetes Authors.


neolit123 · 2018-07-30T23:05:22Z

@noqcks thanks for the PR.
please make sure you run ./hack/update-bazel.sh and include any file changes in this PR.

dims · 2018-07-31T23:31:29Z

/ok-to-test

neolit123 · 2018-07-31T23:39:45Z

@noqcks
hi, the bazel test is complaining about:

I0731 23:35:06.761] /bazel-scratch/.cache/bazel/_bazel_root/e9f728bbd90b3fba632eb31b20e1dacd/sandbox/linux-sandbox/4523/execroot/main/cmd/kube-scheduler/app/options/options.go:188:15: cannot use validation.ValidateKubeSchedulerConfiguration(&o.ComponentConfig) (type field.ErrorList) as type []error in append

edit: have a look at the failing tests logs by clicking their link links.

neolit123 · 2018-08-01T11:42:31Z

@noqcks

the verify test indicates some small problems:
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66799/pull-kubernetes-verify/100514/:

pkg/apis/componentconfig/validation/validation.go:25:1: exported function ValidateKubeSchedulerConfiguration should have comment or be unexported
pkg/apis/componentconfig/validation/validation.go:48:1: exported function ValidateClientConnectionConfiguration should have comment or be unexported
pkg/apis/componentconfig/validation/validation.go:59:1: exported function 
....

neolit123 · 2018-08-01T18:38:19Z

@noqcks the e2e tests flake from time to time.

noqcks · 2018-08-01T19:17:01Z

@neolit123 not sure how I can debug these failed e2e tests 🤔I can't find anything in the logs that shows an error on my side. lmk if you have any ideas.

neolit123 · 2018-08-01T19:19:26Z

@noqcks

possibly flakes, still.
hint: call /test on the red [x] tests only.

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-device-plugin-gpu
/test pull-kubernetes-kubemark-e2e-gce-big

neolit123 · 2018-08-01T19:35:10Z

@noqcks
just babysit the tests with the /test xxxxxx command until they become green.

noqcks · 2018-08-01T19:37:23Z

I may try again a little later tonight. I checked a couple other PRs and they also seem to be failing e2e tests in the same manner.

Thank you for the help

cblecker · 2018-08-01T20:44:16Z

/retest

neolit123 · 2018-08-01T21:43:42Z

pkg/apis/componentconfig/validation/validation.go

-	if cc.File == nil && cc.ConfigMap == nil {
-		allErrs = append(allErrs, field.Invalid(fldPath.Child("file"), nil, "needs to set either File or ConfigMap"))
+	if cc == nil {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("policy"), nil, "need to set Policy"))


could be refactored as:

allErrs := field.ErrorList{} if cc == nil { return append(allErrs, field.Invalid(fldPath.Child("policy"), nil, "need to set Policy")) } if cc.File == nil && cc.ConfigMap == nil { return append(allErrs, field.Invalid(fldPath.Child("file"), nil, "need to set either File or ConfigMap")) } return allErrs

to avoid indenting the } else part.

noqcks · 2018-08-02T20:24:58Z

@neolit123 pull-kubernetes-kubemark-e2e-gce-big seems to be running an older commit 🤔 Is there a way I can make it run on 31e73be

bsalamat · 2018-08-02T20:26:11Z

cmd/kube-scheduler/app/options/deprecated_test.go

+
+func TestValidateDeprecatedKubeSchedulerConfiguration(t *testing.T) {
+	scenarios := map[string]struct {
+		isExpectedFailure bool


optional: s/isExpectedFailure/expectedToFail/

bsalamat · 2018-08-02T20:28:17Z

pkg/apis/componentconfig/validation/validation_test.go

+	"time"
+)
+
+func TestValidateKubeSchedulerConfiguration(t *testing.T) {


The use of different algorithm providers are not very important in my opinion. Actually, I think it is not used anymore (I am not sure though).

bsalamat · 2018-08-02T22:57:03Z

pkg/apis/componentconfig/validation/validation.go

+// ValidateSchedulerPolicySource ensures validation of the SchedulerPolicySource struct
+func ValidateSchedulerPolicySource(cc *componentconfig.SchedulerPolicySource, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+	if cc.File == nil && cc.ConfigMap == nil {


Scheduler policy is not mandatory. If no policy is provided, the scheduler uses its own default config.

bsalamat · 2018-08-02T22:59:09Z

pkg/apis/componentconfig/validation/validation.go

+// ValidateClientConnectionConfiguration ensures validation of the ClientConnectionConfiguration struct
+func ValidateClientConnectionConfiguration(cc *componentconfig.ClientConnectionConfiguration, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+	if len(cc.KubeConfigFile) == 0 {


I don't think KubeConfigFile is mandatory either.

bsalamat · 2018-08-02T23:02:34Z

pkg/apis/componentconfig/validation/validation.go

+// ValidateKubeSchedulerLeaderElectionConfiguration ensures validation of the KubeSchedulerLeaderElectionConfiguration struct
+func ValidateKubeSchedulerLeaderElectionConfiguration(cc *componentconfig.KubeSchedulerLeaderElectionConfiguration, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+	allErrs = append(allErrs, ValidateLeaderElectionConfiguration(&cc.LeaderElectionConfiguration, field.NewPath("leaderElectionConfiguration"))...)


We should validate leader election config only when leader election is enabled.

bsalamat · 2018-08-02T23:04:49Z

pkg/apis/componentconfig/validation/validation.go

+// ValidateLeaderElectionConfiguration ensures validation of the LeaderElectionConfiguration struct
+func ValidateLeaderElectionConfiguration(cc *componentconfig.LeaderElectionConfiguration, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+	if cc.LeaseDuration.Duration <= 0 {


I am not sure if 0 is a valid Duration. If it is not, the error message at the next line should be changed.

I think no as well: https://github.com/kubernetes/kubernetes/pull/64218/files

will change

bsalamat · 2018-08-02T23:05:25Z

pkg/apis/componentconfig/validation/validation.go

+	if cc.RenewDeadline.Duration > cc.LeaseDuration.Duration {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("renewDeadline"), cc.RenewDeadline, "RenewDeadline must be less than or equal to LeaseDuration"))
+	}
+	if cc.RetryPeriod.Duration <= 0 {


similar to the previous comment.

bsalamat · 2018-08-03T17:54:58Z

pkg/apis/componentconfig/validation/validation.go

+	if !cc.LeaderElect {
+		return allErrs
+	}
+	if cc.LeaseDuration.Duration < 1 {


Actually, the error condition should remain as cc.LeaseDuration.Duration <= 0 here and below.

noqcks · 2018-08-07T02:36:27Z

ready for another review on this I believe @bsalamat

bsalamat

Thanks, @noqcks! Mostly minor comments.

bsalamat · 2018-08-08T18:58:43Z

pkg/apis/componentconfig/validation/validation.go

+	for _, msg := range validation.IsValidSocketAddr(cc.MetricsBindAddress) {
+		allErrs = append(allErrs, field.Invalid(field.NewPath("metricsBindAddress"), cc.MetricsBindAddress, msg))
+	}
+	if 0 <= cc.HardPodAffinitySymmetricWeight && cc.HardPodAffinitySymmetricWeight >= 100 {


0 and 100 are valid. So, you should replace <= and >= with < and >.

bsalamat · 2018-08-08T19:04:42Z

pkg/apis/componentconfig/validation/validation.go

+		return allErrs
+	}
+	if cc.LeaseDuration.Duration <= 0 {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("leaseDuration"), cc.LeaseDuration, "must be non-negative"))


the error message states that the value "must be non-negative". Non-negative includes zero, but zero causes an error. So, the error message should be changed to "must be positive" or "must be larger than zero". The same problem exists in the following checks as well.

bsalamat · 2018-08-08T19:10:00Z

pkg/apis/componentconfig/validation/validation.go

+func ValidateKubeSchedulerLeaderElectionConfiguration(cc *componentconfig.KubeSchedulerLeaderElectionConfiguration, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+	allErrs = append(allErrs, ValidateLeaderElectionConfiguration(&cc.LeaderElectionConfiguration, field.NewPath("leaderElectionConfiguration"))...)
+	if len(cc.LockObjectNamespace) == 0 {


When cc.LeaderElect is false, we should skip these two checks too.

bsalamat · 2018-08-08T19:13:53Z

pkg/apis/componentconfig/validation/validation.go

+	if cc.RetryPeriod.Duration <= 0 {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("retryPeriod"), cc.RetryPeriod, "must be non-negative"))
+	}
+	if cc.LeaseDuration.Duration <= cc.RenewDeadline.Duration {


LeaseDuration and RenewDeadline can be equal and that's not an error. Please replace <= by <.

bsalamat · 2018-08-08T19:32:19Z

pkg/apis/componentconfig/validation/validation_test.go

+		},
+	}
+
+	renewDeadlineExceedsLeaseDuration := validConfig.DeepCopy()


Could you please add test cases for renewDeadline and LeaseDuration being zero as well?

bsalamat

/lgtm

wilberusa · 2018-08-27T19:13:33Z

unsubsribe

…

On Wed, Aug 8, 2018 at 9:42 PM k8s-ci-robot ***@***.***> wrote: @noqcks <https://github.com/noqcks>: The following test *failed*, say /retest to rerun them all: Test name Commit Details Rerun command pull-kubernetes-e2e-gce-100-performance 743a77e <743a77e> link <https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/66799/pull-kubernetes-e2e-gce-100-performance/15524/> /test pull-kubernetes-e2e-gce-100-performance Full PR test history <https://k8s-gubernator.appspot.com/pr/66799>. Your PR dashboard <https://k8s-gubernator.appspot.com/pr/noqcks>. Please help us cut down on flakes by linking to <https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#66799 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALS8Mh0N3HngqJT23oWT35LIpEHT2Yhjks5uO72lgaJpZM4VnInb> .

noqcks · 2018-08-27T20:57:16Z

@luxas ready for review

luxas

/lgtm
Thanks!

luxas · 2018-08-29T12:21:39Z

ping @deads2k @liggitt for the final approval

liggitt · 2018-08-29T15:12:12Z

pkg/scheduler/apis/config/validation/validation.go

+		allErrs = append(allErrs, field.Invalid(field.NewPath("metricsBindAddress"), cc.MetricsBindAddress, msg))
+	}
+	if cc.HardPodAffinitySymmetricWeight < 0 || cc.HardPodAffinitySymmetricWeight > 100 {
+		allErrs = append(allErrs, field.Invalid(field.NewPath("hardPodAffinitySymmetricWeight"), cc.HardPodAffinitySymmetricWeight, "not in valid range 0-100"))


where is this range documented or enforced today? It is described in the API type field godoc, but not in the CLI flag help, which is where most users are currently setting it.

what is the current behavior if a negative number is set via the CLI?

what is the current behavior if a number over 100 is set via the CLI?

documented here: https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/api/v1/types.go#L42

please also add that to the flag help. if setting this to a value less than 0 or greater than 100 does not prevent the scheduler from working today, then I wouldn't make this a fatal error.

added in 3f7830f6826b0ac8b5170f00014d4aaee3fb621f

if setting this to a value less than 0 or greater than 100 does not prevent the scheduler from working today, then I wouldn't make this a fatal error.

can you comment on this? @bsalamat, do you know what the effect of setting this to a value outside the 0-100 range is?

@liggitt Scheduler has a check to ensure that this value is between 1 and 100. This is done at the scheduler creation. So, it was not possible to provide a value out of this range before this PR.

Does that mean the allowed range is 1-100 or 0-100? Or is 0 a marker value that means to disable that weight?

0 is changed to the default weight in our defaulting logic.

I am referring to this piece of code:

kubernetes/pkg/scheduler/apis/config/v1alpha1/defaults.go

Line 43 in 2d7b92e

obj.HardPodAffinitySymmetricWeight = api.DefaultHardPodAffinitySymmetricWeight

liggitt · 2018-08-29T15:13:57Z

staging/src/k8s.io/apiserver/pkg/apis/config/validation/validation.go

+	}
+	if cc.LeaseDuration.Duration < cc.RenewDeadline.Duration {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("leaseDuration"), cc.RenewDeadline, "LeaseDuration must be greater than RenewDeadline"))
+	}


is ResourceLock not required?

added in a5554d8dc7b46622ed8bb3c9fffe21a0ea247f94

liggitt · 2018-08-29T15:15:50Z

staging/src/k8s.io/apimachinery/pkg/apis/config/validation/validation.go

+func ValidateClientConnectionConfiguration(cc *config.ClientConnectionConfiguration, fldPath *field.Path) field.ErrorList {
+	allErrs := field.ErrorList{}
+	if cc.QPS < 0 {
+		allErrs = append(allErrs, field.Invalid(fldPath.Child("qps"), cc.QPS, "must be non-negative"))


this is not accurate... a negative number disables QPS rate limiting today

this is the only validation I see around the client config struct today:

kubernetes/pkg/proxy/apis/config/validation/validation.go

Lines 190 to 194 in 1138727

func validateClientConnectionConfiguration(config apimachineryconfig.ClientConnectionConfiguration, fldPath *field.Path) field.ErrorList {

allErrs := field.ErrorList{}

allErrs = append(allErrs, apivalidation.ValidateNonnegativeField(int64(config.Burst), fldPath.Child("Burst"))...)

return allErrs

}

that could be useful to promote to a reusable method

Thanks, I'll fix.

For Burst, is there any range that's not accepted?

liggitt · 2018-08-29T15:16:47Z

staging/src/k8s.io/apimachinery/pkg/apis/config/validation/validation_test.go

+	}
+
+	qpsLessThanZero := validConfig.DeepCopy()
+	qpsLessThanZero.QPS = -1


negative numbers are accepted today and disable client-side rate limiting. please add a test ensuring this continues to be accepted.

added in 125f64b

noqcks · 2018-08-29T20:10:36Z

@liggitt ready for another review

liggitt · 2018-08-31T23:56:06Z

One last question on the 0-100 range, might need a doc update depending on what is actually allowed. Lgtm otherwise after a squash

liggitt · 2018-09-01T01:31:10Z

/approve

will leave lgtm to @bsalamat after squash

@bsalamat

adding validation for componentconfig adding validation to cmd kube-scheduler Add support for ipv6 in IsValidSocketAddr function updating copyright date in componentconfig/validation/validation.go updating copyright date in componentconfig/validation/validation_test.go adding validation for cli options adding BUILD files updating validate function to return []errors in cmd/kube-scheduler ok, really returning []error this time adding comments for exported componentconfig Validation functions silly me, not checking structs along the way :'( refactor to avoid else statement moving policy nil check up one function rejigging some deprecated cmd validations stumbling my way around validation slowly but surely updating according to review from @bsalamat - not validating leader election config unless leader election is enabled - leader election time values cannot be zero - removing validation for KubeConfigFile - removing validation for scheduler policy leader elect options should be non-negative adding test cases for renewDeadline and leaseDuration being zero fixing logic in componentconfig validation 😅 removing KubeConfigFile reference from tests as it was removed in master kubernetes@2ff9bd6 removing bogus space after var assignment adding more tests for componentconfig based on feedback making updates to validation because types were moved on master update bazel build adding validation for staging/apimachinery adding validation for staging/apiserver adding fieldPaths for staging validations moving staging validations out of componentconfig updating test case scenario for staging/apimachinery ./hack/update-bazel.sh moving kube-scheduler validations from componentconfig ./hack/update-bazel.sh removing non-negative check for QPS resourceLock required adding HardPodAffinitySymmetricWeight 0-100 range to cmd flag help section

noqcks · 2018-09-01T02:30:43Z

squashed

bsalamat

/lgtm

k8s-ci-robot · 2018-09-03T17:35:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, liggitt, luxas, noqcks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/kube-scheduler/OWNERS~~ [bsalamat]
~~pkg/scheduler/apis/config/OWNERS~~ [bsalamat,liggitt,luxas]
~~staging/src/k8s.io/apimachinery/pkg/OWNERS~~ [liggitt]
~~staging/src/k8s.io/apiserver/pkg/apis/config/OWNERS~~ [liggitt,luxas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fejta-bot · 2018-09-03T22:19:45Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-github-robot · 2018-09-03T23:10:08Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-09-04T00:17:49Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

k8s-ci-robot requested review from mikedanese and timothysc July 30, 2018 20:41

k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jul 30, 2018

k8s-ci-robot assigned bsalamat Jul 30, 2018

bsalamat reviewed Jul 30, 2018

View reviewed changes

neolit123 reviewed Jul 30, 2018

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2018

neolit123 reviewed Aug 1, 2018

View reviewed changes

bsalamat reviewed Aug 2, 2018

View reviewed changes

bsalamat reviewed Aug 3, 2018

View reviewed changes

timothysc removed their request for review August 4, 2018 15:12

bsalamat reviewed Aug 8, 2018

View reviewed changes

noqcks force-pushed the master branch from f97add2 to 347fc2a Compare August 27, 2018 15:46

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2018

noqcks force-pushed the master branch from 347fc2a to 1d334d7 Compare August 27, 2018 16:56

bsalamat added this to the v1.12 milestone Aug 27, 2018

bsalamat added the status/approved-for-milestone label Aug 27, 2018

bsalamat approved these changes Aug 27, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2018

luxas approved these changes Aug 29, 2018

View reviewed changes

liggitt reviewed Aug 29, 2018

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2018

noqcks force-pushed the master branch from 3f7830f to 0334a34 Compare September 1, 2018 02:30

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2018

bsalamat reviewed Sep 3, 2018

View reviewed changes

k8s-github-robot merged commit f3b98a0 into kubernetes:master Sep 4, 2018

	func validateClientConnectionConfiguration(config apimachineryconfig.ClientConnectionConfiguration, fldPath *field.Path) field.ErrorList {
	allErrs := field.ErrorList{}
	allErrs = append(allErrs, apivalidation.ValidateNonnegativeField(int64(config.Burst), fldPath.Child("Burst"))...)
	return allErrs
	}

Add validation for kube-scheduler configuration options #66799

Add validation for kube-scheduler configuration options #66799

Conversation

noqcks commented Jul 30, 2018 • edited Loading

noqcks commented Jul 30, 2018

bsalamat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 commented Jul 30, 2018

dims commented Jul 31, 2018

neolit123 commented Jul 31, 2018 • edited Loading

neolit123 commented Aug 1, 2018

neolit123 commented Aug 1, 2018

noqcks commented Aug 1, 2018

neolit123 commented Aug 1, 2018

neolit123 commented Aug 1, 2018

noqcks commented Aug 1, 2018 • edited Loading

cblecker commented Aug 1, 2018

Choose a reason for hiding this comment

noqcks commented Aug 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noqcks Aug 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noqcks commented Aug 7, 2018

bsalamat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsalamat left a comment

Choose a reason for hiding this comment

wilberusa commented Aug 27, 2018 via email

noqcks commented Aug 27, 2018

luxas left a comment

Choose a reason for hiding this comment

luxas commented Aug 29, 2018

liggitt Aug 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liggitt Aug 31, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noqcks Aug 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noqcks commented Aug 29, 2018

noqcks commented Jul 30, 2018 •

edited

Loading

neolit123 commented Jul 31, 2018 •

edited

Loading

noqcks commented Aug 1, 2018 •

edited

Loading

noqcks Aug 3, 2018 •

edited

Loading

liggitt Aug 29, 2018 •

edited

Loading

liggitt Aug 31, 2018 •

edited

Loading

noqcks Aug 29, 2018 •

edited

Loading