Block dry-run if a webhook would be called #67085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/lgtm API changes often take longer than expected... |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jennybuckley, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-kubemark-e2e-gce-big |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 67085, 66559, 67089). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 15, 2018
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add unit tests for webhooks with dry run **What this PR does / why we need it**: Fixes an issue with #67085 and adds a couple test cases that would catch it. @lavalamp **Release note**: ```release-note NONE ```
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
Aug 16, 2018
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add unit tests for webhooks with dry run **What this PR does / why we need it**: Fixes an issue with kubernetes/kubernetes#67085 and adds a couple test cases that would catch it. @lavalamp **Release note**: ```release-note NONE ``` Kubernetes-commit: c582a37cae02b4d1a850e6668ea8ea0a81dcd204
sttts
pushed a commit
to sttts/apiserver
that referenced
this pull request
Sep 5, 2018
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add unit tests for webhooks with dry run **What this PR does / why we need it**: Fixes an issue with kubernetes/kubernetes#67085 and adds a couple test cases that would catch it. @lavalamp **Release note**: ```release-note NONE ``` Kubernetes-commit: c582a37cae02b4d1a850e6668ea8ea0a81dcd204
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
Sep 6, 2018
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add unit tests for webhooks with dry run **What this PR does / why we need it**: Fixes an issue with kubernetes/kubernetes#67085 and adds a couple test cases that would catch it. @lavalamp **Release note**: ```release-note NONE ``` Kubernetes-commit: c582a37cae02b4d1a850e6668ea8ea0a81dcd204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up to #66391
Suggested in #66391 (comment)
Makes dry-run safe in case #66936 takes a long time to merge
Release note:
/sig api-machinery
cc @lavalamp