Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block dry-run if a webhook would be called #67085

Merged
merged 1 commit into from Aug 7, 2018

Conversation

Projects
None yet
4 participants
@jennybuckley
Copy link
Contributor

jennybuckley commented Aug 7, 2018

What this PR does / why we need it:
Follow up to #66391
Suggested in #66391 (comment)

Makes dry-run safe in case #66936 takes a long time to merge

Release note:

NONE

/sig api-machinery
cc @lavalamp

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Aug 7, 2018

/lgtm
/approve

API changes often take longer than expected...

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Aug 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jennybuckley, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

jennybuckley commented Aug 7, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Aug 7, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

jennybuckley commented Aug 7, 2018

/retest

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Aug 7, 2018

Automatic merge from submit-queue (batch tested with PRs 67085, 66559, 67089). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 47878f2 into kubernetes:master Aug 7, 2018

16 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-integration
Details
pull-kubernetes-integration Job triggered.
Details
cla/linuxfoundation jennybuckley authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-github-robot pushed a commit that referenced this pull request Aug 15, 2018

Kubernetes Submit Queue
Merge pull request #67099 from jennybuckley/dry-run-admission-3
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add unit tests for webhooks with dry run

**What this PR does / why we need it**:
Fixes an issue with #67085 and adds a couple test cases that would catch it.

@lavalamp

**Release note**:

```release-note
NONE
```

k8s-publishing-bot added a commit to kubernetes/apiserver that referenced this pull request Aug 16, 2018

Merge pull request #67099 from jennybuckley/dry-run-admission-3
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add unit tests for webhooks with dry run

**What this PR does / why we need it**:
Fixes an issue with kubernetes/kubernetes#67085 and adds a couple test cases that would catch it.

@lavalamp

**Release note**:

```release-note
NONE
```

Kubernetes-commit: c582a37cae02b4d1a850e6668ea8ea0a81dcd204

sttts pushed a commit to sttts/apiserver that referenced this pull request Sep 5, 2018

Merge pull request #67099 from jennybuckley/dry-run-admission-3
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add unit tests for webhooks with dry run

**What this PR does / why we need it**:
Fixes an issue with kubernetes/kubernetes#67085 and adds a couple test cases that would catch it.

@lavalamp

**Release note**:

```release-note
NONE
```

Kubernetes-commit: c582a37cae02b4d1a850e6668ea8ea0a81dcd204

k8s-publishing-bot added a commit to kubernetes/apiserver that referenced this pull request Sep 6, 2018

Merge pull request #67099 from jennybuckley/dry-run-admission-3
Automatic merge from submit-queue (batch tested with PRs 67396, 67097, 67395, 67365, 67099). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add unit tests for webhooks with dry run

**What this PR does / why we need it**:
Fixes an issue with kubernetes/kubernetes#67085 and adds a couple test cases that would catch it.

@lavalamp

**Release note**:

```release-note
NONE
```

Kubernetes-commit: c582a37cae02b4d1a850e6668ea8ea0a81dcd204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.