-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic audit configuration #67257
dynamic audit configuration #67257
Conversation
b4dea80
to
27b657b
Compare
please, change the release note from /kind feature |
oh and thanks for working on this! :) |
@tallclair @liggitt still have a couple tests to write but functionality is working, would love some early feedback if you have time 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went trough the whole DIFF.
the code seems well written to me as much as i understand the change.
added a couple of styling comments mostly.
👍
staging/src/k8s.io/apiserver/pkg/apis/audit/v1alpha1/register.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/apis/audit/v1alpha1/register.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/apis/audit/v1alpha1/register.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/apis/audit/v1alpha1/register.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/util/webhook/config/kubeconfig.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/util/webhook/config/kubeconfig.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apiserver/pkg/util/webhook/config/serviceresolver_test.go
Outdated
Show resolved
Hide resolved
7a66485
to
8b94330
Compare
/uncc Feel free to add me back when this is no longer wip |
9813c0f
to
9397869
Compare
/retest |
I only looked at the options wiring. Minor comments. Structure-wise, I think it fits in ok. |
for the options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is way easier to follow, thanks for cleaning it up
the questions around the default non-configurable namespaces chosen for recording events are the main blocker.
other than that, just a couple clarifications/comments requested
staging/src/k8s.io/apiextensions-apiserver/pkg/cmd/server/options/options.go
Outdated
Show resolved
Hide resolved
/lgtm |
tagging based on options approval in |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: liggitt, pbarker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pbarker: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Review the full test history for this PR. Silence the bot with an |
What this PR does / why we need it:
Implements dynamic audit configuration feature kubernetes/enhancements#600
Special notes for your reviewer:
The PR depends on the plugins PR #70021
This PR has performance implications when the feature is enabled. This was discussed in the KEP and will be benchmarked and evaluated before moving to beta.
Integration test can be found #69902
Issues that need to be completed before beta can be found #70816
Release note: