Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic audit configuration #67257

Merged
merged 2 commits into from
Nov 15, 2018
Merged

dynamic audit configuration #67257

merged 2 commits into from
Nov 15, 2018

Conversation

pbarker
Copy link
Contributor

@pbarker pbarker commented Aug 10, 2018

What this PR does / why we need it:
Implements dynamic audit configuration feature kubernetes/enhancements#600

Special notes for your reviewer:

The PR depends on the plugins PR #70021

This PR has performance implications when the feature is enabled. This was discussed in the KEP and will be benchmarked and evaluated before moving to beta.

Integration test can be found #69902

Issues that need to be completed before beta can be found #70816

Release note:

Adds DynamicAuditing feature which allows for the configuration of audit webhooks through the use of an AuditSink API object.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2018
@pbarker pbarker changed the title [WIP] adds dynamic audit configuration [WIP] dynamic audit configuration Aug 10, 2018
@pbarker pbarker force-pushed the audit branch 3 times, most recently from b4dea80 to 27b657b Compare August 10, 2018 19:48
@neolit123
Copy link
Member

neolit123 commented Aug 10, 2018

please, change the release note from
Adds dynamic audit configuration -> Add dynamic audit configuration or even better - expand a little on what the feature does for users who don't know.

/kind feature
/sig auth

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Aug 10, 2018
@neolit123
Copy link
Member

oh and thanks for working on this! :)

@pbarker
Copy link
Contributor Author

pbarker commented Aug 10, 2018

@tallclair @liggitt still have a couple tests to write but functionality is working, would love some early feedback if you have time 🙏

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went trough the whole DIFF.
the code seems well written to me as much as i understand the change.

added a couple of styling comments mostly.
👍

@pbarker pbarker force-pushed the audit branch 2 times, most recently from 7a66485 to 8b94330 Compare August 12, 2018 23:42
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2018
@fejta
Copy link
Contributor

fejta commented Aug 13, 2018

/uncc

Feel free to add me back when this is no longer wip

@k8s-ci-robot k8s-ci-robot removed the request for review from fejta August 13, 2018 21:09
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Aug 15, 2018
@pbarker pbarker changed the title [WIP] dynamic audit configuration dynamic audit configuration Aug 15, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2018
@pbarker
Copy link
Contributor Author

pbarker commented Nov 14, 2018

/retest

@deads2k
Copy link
Contributor

deads2k commented Nov 14, 2018

I only looked at the options wiring. Minor comments. Structure-wise, I think it fits in ok.

@deads2k
Copy link
Contributor

deads2k commented Nov 14, 2018

** deads2k ** approved these changes 13 seconds ago

for the options.

@liggitt liggitt self-assigned this Nov 14, 2018
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is way easier to follow, thanks for cleaning it up

the questions around the default non-configurable namespaces chosen for recording events are the main blocker.

other than that, just a couple clarifications/comments requested

@liggitt
Copy link
Member

liggitt commented Nov 15, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
@liggitt
Copy link
Member

liggitt commented Nov 15, 2018

tagging based on options approval in
#67257 (comment)

@liggitt liggitt added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: liggitt, pbarker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 15, 2018

@pbarker: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized b793c3b link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b1a52a3 into kubernetes:master Nov 15, 2018
@pbarker pbarker deleted the audit branch November 19, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet