Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated fluentd to 1.2.4 #67434

Merged
merged 1 commit into from Aug 16, 2018

Conversation

@monotek
Copy link
Member

monotek commented Aug 15, 2018

What this PR does / why we need it:

  • updates fluentd in fluentd-elasticsearch to version 1.2.4
  • also updates activesupport, fluent-plugin-elasticsearch & oj gems

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

* updates fluentd in fluentd-elasticsearch to version 1.2.4
* also updates activesupport, fluent-plugin-elasticsearch & oj gems
@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented Aug 15, 2018

/cc dixudx

@k8s-ci-robot k8s-ci-robot requested a review from dixudx Aug 15, 2018

@monotek

This comment has been minimized.

Copy link
Member Author

monotek commented Aug 15, 2018

/assign @coffeepac

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Aug 15, 2018

@monotek
please add a release note.
/ok-to-test

@monotek

This comment has been minimized.

Copy link
Member Author

monotek commented Aug 15, 2018

release notes added...

@coffeepac

This comment has been minimized.

Copy link
Member

coffeepac commented Aug 15, 2018

/approve
/retest

@dixudx

dixudx approved these changes Aug 16, 2018

Copy link
Member

dixudx left a comment

/lgtm

Please update cluster/addons/fluentd-elasticsearch/fluentd-es-ds.yaml accordingly to use latest v2.3.0 after this PR gets merged.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Aug 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, dixudx, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Aug 16, 2018

Automatic merge from submit-queue (batch tested with PRs 64445, 67459, 67434). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit dbe3b1a into kubernetes:master Aug 16, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation monotek authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@monotek

This comment has been minimized.

Copy link
Member Author

monotek commented Aug 16, 2018

@coffeepac

Seems theres is still no automatic build of the image:

https://console.cloud.google.com/gcr/images/google-containers/GLOBAL/fluentd-elasticsearch?gcrImageListsize=50

Are these build jobs available in a repo, where i can contribute?
If so, where?

@coffeepac

This comment has been minimized.

Copy link
Member

coffeepac commented Aug 16, 2018

nope. this is a google-internal image. Its on my list to make it not that. I'll file an issue against myself so I stop letting it fall off my list.

@aleks-mariusz

This comment has been minimized.

Copy link

aleks-mariusz commented Aug 16, 2018

any ideas when this will be generally available publicly to start using ?

@coffeepac

This comment has been minimized.

Copy link
Member

coffeepac commented Aug 16, 2018

@aleks-mariusz I'm waiting for #67484 (comment) to get merged before I ask a googler to build. they can kick both jobs off at once. after that it will take ~24 hours.

Due to team geography (Ie: they're sleeping soon) I expect this will take ~36 hours

@aleks-mariusz

This comment has been minimized.

Copy link

aleks-mariusz commented Aug 17, 2018

cool, but i saw a typo in that issue (the first part of the commit has 6.3.2 but the second has 6.3.0).. made a mention of this on that issue as well.

@coffeepac

This comment has been minimized.

Copy link
Member

coffeepac commented Aug 22, 2018

@aleks-mariusz available now, though its v2.3.1 . v2.3.0 wasn't built.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Aug 24, 2018

/sig instrumentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.