Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #67456: fix an issue in NodeInfo.Clone() #67481

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Automated cherry pick of #67456: fix an issue in NodeInfo.Clone() #67481

merged 1 commit into from
Aug 20, 2018
+8 −2

Conversation

Huang-Wei
Copy link
Member

Cherry pick of #67456 on release-1.11.

#67456: fix an issue in NodeInfo.Clone()

@Huang-Wei
fix an issue in NodeInfo.Clone()
32fe801 
- usedPorts is a map-in-map struct, add fix to ensure it's deep copied
- updated unit test
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 16, 2018
@Huang-Wei
Copy link
Member Author

/assign @bsalamat

This is a cherrypick PR to 1.11. PTAL.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2018
bsalamat
bsalamat approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2018
@bsalamat bsalamat added this to the v1.11 milestone Aug 16, 2018
@bsalamat
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2018
@bsalamat bsalamat added status/approved-for-milestone kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Aug 16, 2018
@Huang-Wei
Copy link
Member Author

/assign @foxish

It's a cherrypick candidate to 1.11.

@Huang-Wei
Copy link
Member Author

/retest

@foxish foxish added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 20, 2018
@Huang-Wei
Copy link
Member Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit c7130d0 into kubernetes:release-1.11 Aug 20, 2018
@Huang-Wei Huang-Wei deleted the automated-cherry-pick-of-#67456-upstream-release-1.11 branch August 20, 2018 20:30
@Huang-Wei Huang-Wei mentioned this pull request Aug 28, 2018
Closed
6 tasks
@aveshagarwal aveshagarwal mentioned this pull request Dec 11, 2018
Merged
@ravisantoshgudimetla ravisantoshgudimetla mentioned this pull request Jan 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat approved these changes

@resouer resouer Awaiting requested review from resouer

Assignees

@foxish foxish

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Huang-Wei @k8s-ci-robot @bsalamat @k8s-github-robot @foxish