UPSTREAM: 67456:fix an issue in NodeInfo.Clone()

[ravisantoshgudimetla]

Upstream PRs:
kubernetes/kubernetes#67481

This fix is not part of 1.12.2 that we are rebasing to so it is needed. Could be responsible for flakes from scheduler side.

/cc @sjenning @smarterclayton

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ravisantoshgudimetla
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vendor/k8s.io/kubernetes/pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ravisantoshgudimetla]

/cc @aveshagarwal,

https://github.com/openshift/origin/pull/21649/files the PR that landed to 3.11

[aveshagarwal]

I had already created this PR for master: #20672 but it was closed as it was supposed to come via rebase.

@soltysh

[ravisantoshgudimetla]

@aveshagarwal - I am fine with closing this PR and you re-opening the old PR but seems the kube v1.12.2 branch(https://github.com/kubernetes/kubernetes/blob/v1.12.2/pkg/scheduler/cache/cache.go) is not having the commit we need nor does @soltysh's rebase PR. @soltysh correct me if I am wrong.

[aveshagarwal]

that code is part of 1.12: https://github.com/kubernetes/kubernetes/blob/release-1.12/pkg/scheduler/cache/node_info.go#L403-#L408

[ravisantoshgudimetla]

I was under the impression that we are pulling in kube upstream and https://github.com/kubernetes/kubernetes/blob/v1.12.2/pkg/scheduler/cache/cache.go(which doesn't have the commit) but it seems we are actually pulling in from our fork of kube within openshift org and https://github.com/openshift/kubernetes/blob/origin-4.0-kubernetes-1.12.2/pkg/scheduler/cache/node_info.go has the changes needed.

[ravisantoshgudimetla]

So, it is safe to close the PR.

[openshift-ci-robot]

@ravisantoshgudimetla: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-serial	1c84521	link	/test e2e-aws-serial
ci/prow/e2e-aws	1c84521	link	/test e2e-aws
ci/prow/images	1c84521	link	/test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[r2dito]

Unsubscribe Thanks! BR, Rommel

…

On Jan 9, 2019, at 4:32 PM, RaviSantosh Gudimetla ***@***.***> wrote: I was under the impression that we are pulling in kube upstream and https://github.com/kubernetes/kubernetes/blob/v1.12.2/pkg/scheduler/cache/cache.go(which doesn't have the commit) but it seems we are actually pulling in from our fork of kube within openshift org and https://github.com/openshift/kubernetes/blob/origin-4.0-kubernetes-1.12.2/pkg/scheduler/cache/node_info.go has the changes needed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.