kubeadm: use ClusterConfiguration in images.go

[rosti]

What this PR does / why we need it:

This PR is the first in a series, targeting the replacement of InitConfiguration with ClusterConfiguration, when the former is not needed. Please, review only the last commit.

Replace the unnecessary use of InitConfiguration in images.go with ClusterConfiguration. This changes the interfaces of the following functions:

• GetKubeControlPlaneImage
• GetEtcdImage
• GetAllImages

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
refs kubernetes/kubeadm#963

Special notes for your reviewer:

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/kind enhancement
/assign @luxas
/assign @timothysc
/assign @fabriziopandini

Depends on:

• [reissue] kubeadm: Split out ClusterConfiguration from InitConfiguration #67441

Release note:

NONE

[fabriziopandini]

@rosti +100 for jumping in and helping on @luxas work!

/approve

Being this so big, I kindly ask @timothysc or @liztio (or *) to give a second pass + final lgtm

[chuckha]

the last commit here looks good, just waiting on the parent PR to merge

[timothysc]

/hold

I'm just going to put a hold on this one till the other PRs clear out. We have a bunch of large PRs in flight in the merge queue. I have no idea why they are taking so long, but I will check back on this one tomorrow.

[rosti]

/test pull-kubernetes-e2e-gce

[timothysc]

/lgtm
/approve

I'm very frustrated by stuff like this. I feel like we need to abstract our internal data handling, or perhaps when we reach beta this will be less of an issue...

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, rosti, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kubeadm/OWNERS [fabriziopandini,timothysc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rosti]

@timothysc Thanks for the approval.

I'm very frustrated by stuff like this. I feel like we need to abstract our internal data handling, or perhaps when we reach beta this will be less of an issue...

I am too, but I view this more like the "necessary evil". Abstractions can be cumbersome sometimes and I think that we should first try reaching beta this way (before going into abstractions).

[timothysc]

/test pull-kubernetes-e2e-gce

[timothysc]

/test pull-kubernetes-e2e-kops-aws

[timothysc]

/test pull-kubernetes-e2e-kops-aws

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 67776, 67503, 67679, 67786, 67830). If you want to cherry-pick this change to another branch, please follow the instructions here.