Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: use ClusterConfiguration in images.go #67503

Merged

Conversation

@rosti
Copy link
Member

commented Aug 16, 2018

What this PR does / why we need it:

This PR is the first in a series, targeting the replacement of InitConfiguration with ClusterConfiguration, when the former is not needed. Please, review only the last commit.

Replace the unnecessary use of InitConfiguration in images.go with ClusterConfiguration. This changes the interfaces of the following functions:

  • GetKubeControlPlaneImage
  • GetEtcdImage
  • GetAllImages

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
refs kubernetes/kubeadm#963

Special notes for your reviewer:

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/kind enhancement
/assign @luxas
/assign @timothysc
/assign @fabriziopandini

Depends on:

Release note:

NONE
@fabriziopandini
Copy link
Contributor

left a comment

@rosti +100 for jumping in and helping on @luxas work!

/approve

Being this so big, I kindly ask @timothysc or @liztio (or *) to give a second pass + final lgtm

@neolit123 neolit123 referenced this pull request Aug 17, 2018

Closed

Tracking issue for "Config to v1beta1" #963

19 of 28 tasks complete
@chuckha

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

the last commit here looks good, just waiting on the parent PR to merge

@rosti rosti force-pushed the rosti:kubeadm_clusterconfig_images branch from b5ae84b to bde91ee Aug 17, 2018

@rosti rosti force-pushed the rosti:kubeadm_clusterconfig_images branch 2 times, most recently from acdc496 to f1e8d8e Aug 22, 2018

@timothysc

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

/hold

I'm just going to put a hold on this one till the other PRs clear out. We have a bunch of large PRs in flight in the merge queue. I have no idea why they are taking so long, but I will check back on this one tomorrow.

kubeadm: use ClusterConfiguration in images.go
Replace the unnecessary use of InitConfiguration in images.go with
ClusterConfiguration. This changes the interfaces of the following functions:

- GetKubeControlPlaneImage
- GetEtcdImage
- GetAllImages

Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>

@rosti rosti force-pushed the rosti:kubeadm_clusterconfig_images branch from f1e8d8e to de39f49 Aug 23, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XXL labels Aug 23, 2018

@rosti

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2018

/test pull-kubernetes-e2e-gce

@timothysc
Copy link
Member

left a comment

/lgtm
/approve

I'm very frustrated by stuff like this. I feel like we need to abstract our internal data handling, or perhaps when we reach beta this will be less of an issue...

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, rosti, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rosti

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2018

@timothysc Thanks for the approval.

I'm very frustrated by stuff like this. I feel like we need to abstract our internal data handling, or perhaps when we reach beta this will be less of an issue...

I am too, but I view this more like the "necessary evil". Abstractions can be cumbersome sometimes and I think that we should first try reaching beta this way (before going into abstractions).

@timothysc

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

/test pull-kubernetes-e2e-gce

@timothysc

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

/test pull-kubernetes-e2e-kops-aws

@timothysc

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

Automatic merge from submit-queue (batch tested with PRs 67776, 67503, 67679, 67786, 67830). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit de80c82 into kubernetes:master Aug 24, 2018

7 of 18 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-bazel-build
Details
pull-kubernetes-bazel-build Job triggered.
Details
pull-kubernetes-bazel-test Job triggered.
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation rosti authorized
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-typecheck Job succeeded.
Details

@rosti rosti deleted the rosti:kubeadm_clusterconfig_images branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.