-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: Migrate cert and PKI helpers to ClusterConfiguration #67542
Conversation
/hold |
Replace the unnecessary use of InitConfiguration in images.go with ClusterConfiguration. This changes the interfaces of the following functions: - GetKubeControlPlaneImage - GetEtcdImage - GetAllImages Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
The certificate and PKI related helper APIs used InitConfiguration. With the introduction of ClusterConfiguration it became more viable to use that instead (in most cases in combination with NodeRegistrationOptions). This change will allow us to avoid the use of InitConfiguration outside of kubeadm init. Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
9a9eecc
to
8ebca43
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rosti If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini I can see your point here and I agree with the hold. |
We are going to need to lock down the config for 1.12 and punt the rest of the shuffling to try and make a complete push to beta in 1.13. |
@rosti: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
do we still need this for 1.13? |
Not in this form and certainly this should not have a high priority. I'll close this for now. /close |
@rosti: Closing this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR is the second in a series, targeting the replacement of InitConfiguration with ClusterConfiguration, when the former is not needed. Please, review only the last commit.
This PR migrates cert and PKI helper APIs to use ClusterConfiguration (and away from InitConfiguration).
The certificate and PKI related helper APIs used InitConfiguration. With the introduction of ClusterConfiguration it became more viable to use that instead (in most cases in combination with NodeRegistrationOptions).
This change will allow us to avoid the use of InitConfiguration outside of kubeadm init
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):refs kubernetes/kubeadm#963
Special notes for your reviewer:
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/kind enhancement
/assign @luxas
/assign @timothysc
/assign @fabriziopandini
/cc @stealthybox
Depends on:
Release note: