Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter for fluentd-gcp-scaler #67505

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Fix parameter for fluentd-gcp-scaler #67505

merged 1 commit into from
Aug 16, 2018

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Aug 16, 2018

What this PR does / why we need it:
Fixes a parameter for fluentd-gcp-scaler

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 16, 2018
@kawych
Copy link
Contributor Author

kawych commented Aug 16, 2018

/cc @x13n
/cc @bmoyles0117

@k8s-ci-robot k8s-ci-robot requested a review from x13n August 16, 2018 14:21
@k8s-ci-robot
Copy link
Contributor

@kawych: GitHub didn't allow me to request PR reviews from the following users: bmoyles0117.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @x13n
/cc @bmoyles0117

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kawych
Copy link
Contributor Author

kawych commented Aug 16, 2018

/uncc @piosz
/uncc @jszczepkowski

bmoyles0117
bmoyles0117 approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@bmoyles0117 bmoyles0117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@x13n
Copy link
Member

x13n commented Aug 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2018
@kawych
Copy link
Contributor Author

kawych commented Aug 16, 2018

/cc @MaciekPytel

@MaciekPytel
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, MaciekPytel, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67137, 67372, 67505, 67373, 67357). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 871dda7 into kubernetes:master Aug 16, 2018
@kawych kawych mentioned this pull request Aug 17, 2018
Merged
@kawych kawych mentioned this pull request Aug 29, 2018
Merged
@x13n x13n mentioned this pull request Aug 29, 2018
Closed
k8s-github-robot pushed a commit that referenced this pull request Aug 29, 2018
Merge pull request #67535 from kawych/automated-cherry-pick-of-#67505…
86c0fa1 
…-upstream-release-1.11

Automatic merge from submit-queue.

Automated cherry pick of #67505: Fix parameter for fluentd-gcp-scaler

Cherry pick of #67505 on release-1.11.

#67505: Fix parameter for fluentd-gcp-scaler

```release-note
NONE
```
k8s-github-robot pushed a commit that referenced this pull request Sep 4, 2018
Merge pull request #67997 from kawych/automated-cherry-pick-of-#67505…
c80bb53 
…-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #67505: Fix parameter for fluentd-gcp-scaler

Cherry pick of #67505 on release-1.10.

#67505: Fix parameter for fluentd-gcp-scaler

```release-note
NONE
```
@wadadli
Copy link

wadadli commented Sep 13, 2018

Is there a work around for this? I have a prod cluster that's generating these logs.

@x13n
Copy link
Member

x13n commented Sep 13, 2018

This will be fixed in 1.10.8. Meanwhile, the workaround for excessive logging is to filter them out: https://cloud.google.com/logging/docs/exclusions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoyles0117 bmoyles0117 bmoyles0117 approved these changes

@x13n x13n Awaiting requested review from x13n

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@x13n x13n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kawych @k8s-ci-robot @x13n @MaciekPytel @k8s-github-robot @wadadli @bmoyles0117