Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #67505: Fix parameter for fluentd-gcp-scaler #67997

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Automated cherry pick of #67505: Fix parameter for fluentd-gcp-scaler #67997

merged 1 commit into from
Sep 4, 2018

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Aug 29, 2018 •
edited
Loading

Cherry pick of #67505 on release-1.10.

#67505: Fix parameter for fluentd-gcp-scaler

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2018
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 29, 2018
@kawych
Copy link
Contributor Author

kawych commented Aug 29, 2018

/uncc @crassirostris
/cc @piosz

@k8s-ci-robot k8s-ci-robot requested review from piosz and removed request for crassirostris August 29, 2018 09:39
@piosz piosz self-assigned this Aug 29, 2018
@piosz
Copy link
Member

piosz commented Aug 29, 2018

/lgtm
/arprove

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@piosz
Copy link
Member

piosz commented Aug 29, 2018

Please fix e2e

@x13n
Copy link
Member

x13n commented Aug 31, 2018

/retest

@x13n
Copy link
Member

x13n commented Aug 31, 2018

/assign @MaciekPytel

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 3, 2018
@MaciekPytel
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, MaciekPytel, piosz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2018
@kawych
Copy link
Contributor Author

kawych commented Sep 3, 2018

/retest

@MaciekPytel
Copy link
Contributor

/milestone v1.10

@k8s-ci-robot
Copy link
Contributor

@MaciekPytel: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaciekPytel MaciekPytel added this to the v1.10 milestone Sep 4, 2018
@x13n
Copy link
Member

x13n commented Sep 4, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit c80bb53 into kubernetes:release-1.10 Sep 4, 2018
@kawych kawych deleted the automated-cherry-pick-of-#67505-upstream-release-1.10 branch March 29, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@piosz piosz Awaiting requested review from piosz

Assignees

@MaciekPytel MaciekPytel

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kawych @piosz @x13n @MaciekPytel @k8s-ci-robot @fejta-bot @k8s-github-robot