Kubelet: only apply default hard evictions of nodefs.inodesFree on Linux

[feiskyer]

What this PR does / why we need it:

Kubelet sets default hard evictions of nodefs.inodesFree for all platforms today. This will cause errors on Windows and a lot no observation found for eviction signal nodefs.inodesFree errors will be logs for kubelet.

kubelet.err.log:4961:W0711 22:21:12.378789    2872 helpers.go:808] eviction manager: no observation found for eviction signal nodefs.inodesFree
kubelet.err.log:4967:W0711 22:21:30.411371    2872 helpers.go:808] eviction manager: no observation found for eviction signal nodefs.inodesFree
kubelet.err.log:4974:W0711 22:21:48.446456    2872 helpers.go:808] eviction manager: no observation found for eviction signal nodefs.inodesFree
kubelet.err.log:4978:W0711 22:22:06.482441    2872 helpers.go:808] eviction manager: no observation found for eviction signal nodefs.inodesFree

This PR updates the default hard eviction value and only apply nodefs.inodesFree on Linux.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66088

Special notes for your reviewer:

Release note:

Kubelet only applies default hard evictions of nodefs.inodesFree on Linux

[feiskyer]

/assign @tallclair @PatrickLang

[dims]

/lgtm

[feiskyer]

/retest

[PatrickLang]

/approve

[feiskyer]

/retest

[PatrickLang]

/lgtm

[PatrickLang]

@dims can you review after rebase?

[PatrickLang]

/assign @tallclair

[PatrickLang]

/sig windows
(need to track there too, already have LGTM)

[dims]

/test pull-kubernetes-cross

[derekwaynecarr]

/approve

[dchen1107]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, derekwaynecarr, dims, feiskyer, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [dchen1107,derekwaynecarr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

[k8s-ci-robot]

@feiskyer: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-local-e2e-containerized	8255318	link	/test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[miry]

@feiskyer after those changes the tests are not passed in MacOS.

$ go test ./cmd/kubeadm/app/util/config/... -v -run TestConfigFileAndDefaultsToInternalConfig
    --- FAIL: TestConfigFileAndDefaultsToInternalConfig/incompleteYAMLToDefaultedv1beta1 (0.00s)
        initconfiguration_test.go:123: the expected and actual output differs.
            	in: testdata/defaulting/master/incomplete.yaml
            	out: testdata/defaulting/master/defaulted.yaml
            	groupversion: kubeadm.k8s.io/v1beta1
            	diff: 
            --- expected
            +++ actual
            @@ -115,7 +115,6 @@
               imagefs.available: 15%!
            (MISSING)   memory.available: 100Mi
               nodefs.available: 10%!
            (MISSING)-  nodefs.inodesFree: 5%!
            (MISSING) evictionPressureTransitionPeriod: 5m0s
             failSwapOn: true
             fileCheckFrequency: 20s

as you see nodefs.inodesFree: 5% is missing. Do you know any workaround for different os to have passed tests ?

[feiskyer]

as you see nodefs.inodesFree: 5% is missing. Do you know any workaround for different os to have passed tests ?

Yep, it is moved to only Linux now. Let me file another PR to fix this.