Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mixed protocol support for azure load balancer #67986

Merged
merged 1 commit into from
Sep 4, 2018
Merged

add mixed protocol support for azure load balancer #67986

merged 1 commit into from
Sep 4, 2018

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 29, 2018 •
edited
Loading

What this PR does / why we need it:
If user specify service.beta.kubernetes.io/azure-load-balancer-mixed-protocols: "true", azure cloud provider will create both TCP and UDP lb rules, for more details, could refer to #66887

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66887

Special notes for your reviewer:
original reconcileLoadBalancer func is too big, I move part of code implementation to a standalone func createLoadBalancerRule

example service config:

apiVersion: v1
kind: Service
metadata:
  annotations:
    service.beta.kubernetes.io/azure-load-balancer-mixed-protocols: "true"
  name: web
  namespace: default
spec:
  ports:
  - port: 80
    protocol: TCP
    targetPort: 80
  selector:
    app: web
  sessionAffinity: None
  type: LoadBalancer

Release note:

add mixed protocol support for azure load balancer

/kind feature
/sig azure
/assign @feiskyer @khenidak

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 29, 2018
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/azure size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2018
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Aug 29, 2018
feiskyer
feiskyer reviewed Aug 30, 2018
View reviewed changes
pkg/cloudprovider/providers/azure/azure_loadbalancer.go Outdated
}

if serviceapi.NeedsHealthCheck(service) {
if port.Protocol == v1.ProtocolSCTP {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getProtocolsFromKubernetesProtocol() has already checked this, so the check is not needed here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in new commit, PTAL, thanks.

feiskyer
feiskyer reviewed Aug 30, 2018
View reviewed changes
pkg/cloudprovider/providers/azure/azure_loadbalancer.go Outdated
lbFrontendIPConfigID string,
lbBackendPoolID string,
lbName string,
lbIdleTimeout *int32) error {
Copy link
Member

@feiskyer feiskyer Aug 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move expectedProbes and expectedRules to return so that it's much more easier to read

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved all lb rule and probe creation logic into a new func, that would be more clear

feiskyer
feiskyer reviewed Aug 30, 2018
View reviewed changes
pkg/cloudprovider/providers/azure/azure_loadbalancer.go Outdated
@@ -948,6 +894,86 @@ func (az *Cloud) reconcileLoadBalancer(clusterName string, service *v1.Service,
return lb, nil
}

func (az *Cloud) createLoadBalancerRule(
Copy link
Member

@feiskyer feiskyer Aug 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not actually create a rule, could we rename it to reconcileLoadBalancerRule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@andyzhangx
add mixed protocol support for azure load balancer
815d4ba 
add logging

fix lb issue

fix comments

make code more clean
feiskyer
feiskyer approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member

/retest

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

feiskyer
feiskyer approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 4, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 67986, 68210, 67817). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 771bb86 into kubernetes:master Sep 4, 2018
@feiskyer feiskyer mentioned this pull request Feb 8, 2019
Closed
@andyzhangx andyzhangx mentioned this pull request Feb 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@feiskyer feiskyer

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Add support of mixed procotols LoadBalacer service for Azure
5 participants
@andyzhangx @k8s-ci-robot @feiskyer @k8s-github-robot @khenidak