Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #67288: Immediately close the other side of the connection when proxying #68040

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Automated cherry pick of #67288: Immediately close the other side of the connection when proxying #68040

merged 1 commit into from
Sep 25, 2018

Conversation

tossmilestone
Copy link
Member

@tossmilestone tossmilestone commented Aug 30, 2018 •
edited

Cherry pick of #67288 on release-1.9.

#67288: Immediate close the other half of the connection when

Release note:

Immediately close the other side of the connection when proxying.

@MHBauer @tossmilestone
Immediate close the other half of the connection when proxying
c071cca 
 - don't wait for the both sides of the connection to close on their
   own. If one closes there doesn't seem to be any point in continuing
   the other half.
 - for port-forward, this prevents the api-server and kubelet both
   waiting on the other with no result. Normally the connection
   eventually times out. This cleans up the connection appropriately.
 - add a log message on closing the connection that corresponds to
   opening the connection
@k8s-ci-robot
Copy link
Contributor

@tossmilestone:
This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.
To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.
The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2018
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2018
@tossmilestone
Copy link
Member Author

/assign @deads2k

@mbohlool
Copy link
Contributor

Please add a release note to the base PR.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 31, 2018
@tossmilestone tossmilestone changed the title Automated cherry pick of #67288 Automated cherry pick of #67288: Immediately close the other side of the connection when proxying. Aug 31, 2018
@tossmilestone tossmilestone changed the title Automated cherry pick of #67288: Immediately close the other side of the connection when proxying. Automated cherry pick of #67288: Immediately close the other side of the connection when proxying Aug 31, 2018
@tossmilestone
Copy link
Member Author

@mbohlool updated the release note

@tossmilestone
Copy link
Member Author

/assign @liggitt @lavalamp @smarterclayton

@tossmilestone
Copy link
Member Author

/assign @mbohlool

@mbohlool
Copy link
Contributor

release tool will gather release notes from original PRs, please move the release note there.

@tossmilestone
Copy link
Member Author

@mbohlool the original pr already has none release note, and I have no permission to edit the pr. Could you help to do that?

@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2018
@mbohlool mbohlool added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 25, 2018
@mbohlool mbohlool removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: tossmilestone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 15befec into kubernetes:release-1.9 Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@thockin thockin Awaiting requested review from thockin

Assignees

@lavalamp lavalamp

@liggitt liggitt

@smarterclayton smarterclayton

@mbohlool mbohlool

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@tossmilestone @k8s-ci-robot @mbohlool @BenTheElder @lavalamp @liggitt @smarterclayton @deads2k @MHBauer