Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experimental] Counter-part of #68452: make CR coercing decoder respect context from versioning decoder #68370

Closed
wants to merge 1 commit into from
Closed

[experimental] Counter-part of #68452: make CR coercing decoder respect context from versioning decoder #68370

wants to merge 1 commit into from

Conversation

yue9944882
Copy link
Member

@yue9944882 yue9944882 commented Sep 6, 2018 •
edited

/hold

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
it's an experiment for the versioning decoder for #68197. (at least for now)

also, it tries to the bug uncovered by #68035

counter-part of #68452

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2018
@yue9944882 yue9944882 force-pushed the bugfix/custom-resource-convertor branch from 184ec95 to 1477b46 Compare September 6, 2018 16:58
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yue9944882
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: deads2k

If they are not already assigned, you can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fedebongio
Copy link
Contributor

/assign @roycaihw

@yue9944882 yue9944882 force-pushed the bugfix/custom-resource-convertor branch from 1477b46 to 9f97d4d Compare September 7, 2018 03:19
@sttts
Copy link
Contributor

sttts commented Sep 7, 2018

/cc @mbohlool

@mbohlool mbohlool mentioned this pull request Sep 10, 2018
Closed
yue9944882
yue9944882 commented Sep 10, 2018
View reviewed changes
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go Outdated
@@ -747,6 +748,7 @@ func (d schemaCoercingDecoder) Decode(data []byte, defaults *schema.GroupVersion
}
}

obj = obj.DeepCopyObject()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter is never being used

@mbohlool yes. we can either respect forceConversion or do a deepcopy here to force a conversion here

@yue9944882 yue9944882 force-pushed the bugfix/custom-resource-convertor branch from 9f97d4d to 94aa9cc Compare September 10, 2018 04:03
@yue9944882 yue9944882 changed the title experiment: make CR coercing decoder respect context from versioning decoder [experimental] Counter-part of #68452: make CR coercing decoder respect context from versioning decoder Sep 10, 2018
@yue9944882
Copy link
Member Author

yue9944882 commented Oct 25, 2018 •
edited

fixed by #70087

/close

@k8s-ci-robot
Copy link
Contributor

@yue9944882: Closing this PR.

In response to this:

fixes with #70087

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohlool mbohlool mbohlool left review comments

@ncdc ncdc Awaiting requested review from ncdc

@sttts sttts Awaiting requested review from sttts

Assignees

@roycaihw roycaihw

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yue9944882 @k8s-ci-robot @fedebongio @sttts @mbohlool @roycaihw