-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom resource handler in-memory version #70087
Fix custom resource handler in-memory version #70087
Conversation
54f8698
to
e5559bc
Compare
dd3f050
to
77a0071
Compare
/test pull-kubernetes-integration |
Tests are green, ready for review |
staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/etcd.go
Show resolved
Hide resolved
staging/src/k8s.io/apimachinery/pkg/runtime/serializer/versioning/versioning.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/apimachinery/pkg/runtime/serializer/versioning/versioning.go
Outdated
Show resolved
Hide resolved
c7c41fa
to
f24fa25
Compare
f24fa25
to
1c5d3ab
Compare
comments addressed |
/retest |
1 similar comment
/retest |
@sttts any remaining comments? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Allows custom resource handlers to indicate what group-version they wish to deal with internally.
Traditionally, API resource handlers have dealt with "internal" versions, converting data read from etcd and from incoming requests into a "hub" version.
Custom resources have no "internal" version. This causes problems when handler code is asked to perform conversions to that version (done during update, patch, etc).
This PR:
__internal
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #68197
Fixes #68035
Special notes for your reviewer:
Does this PR introduce a user-facing change?: