New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Parallelize with function ParallelizeUntil and formally depre… #68403

Merged
merged 1 commit into from Oct 6, 2018

Conversation

@wgliang
Member

wgliang commented Sep 7, 2018

…cate the Parallelize

What this PR does / why we need it:
And formally deprecate the Parallelize(It's just a variant of ParallelizeUntil).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
This is a follow up PR of #67555
FYI #67555 (comment)

Release note:

Replace Parallelize with function ParallelizeUntil and formally deprecate the Parallelize.
scaleclient "k8s.io/client-go/scale"
"k8s.io/client-go/transport"
"k8s.io/client-go/util/workqueue"
"k8s.io/kubernetes/pkg/api/legacyscheme"

This comment has been minimized.

@wgliang

wgliang Sep 7, 2018

Member

Yeah, here I sorted out the packages.

@wgliang

wgliang Sep 7, 2018

Member

Yeah, here I sorted out the packages.

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Sep 7, 2018

Member

/ping @sttts and @bsalamat

Member

wgliang commented Sep 7, 2018

/ping @sttts and @bsalamat

@roycaihw

This comment has been minimized.

Show comment
Hide comment
@roycaihw

roycaihw Sep 10, 2018

Member

/assign @yliaog

Member

roycaihw commented Sep 10, 2018

/assign @yliaog

@yliaog

This comment has been minimized.

Show comment
Hide comment
@yliaog

yliaog Sep 10, 2018

Contributor

/lgtm

Contributor

yliaog commented Sep 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 10, 2018

@wojtek-t

This comment has been minimized.

Show comment
Hide comment
@wojtek-t

wojtek-t Sep 11, 2018

Member

/approve

Member

wojtek-t commented Sep 11, 2018

/approve

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Sep 12, 2018

Member

@wojtek-t
Will we merge in v.1.12?

Member

wgliang commented Sep 12, 2018

@wojtek-t
Will we merge in v.1.12?

@wojtek-t

This comment has been minimized.

Show comment
Hide comment
@wojtek-t

wojtek-t Sep 12, 2018

Member

Will we merge in v.1.12?

No - it's code-freeze already, and it's not a bug fix or anything like that.

Member

wojtek-t commented Sep 12, 2018

Will we merge in v.1.12?

No - it's code-freeze already, and it's not a bug fix or anything like that.

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Sep 12, 2018

Member

@wojtek-t
Ok, make sense.

Member

wgliang commented Sep 12, 2018

@wojtek-t
Ok, make sense.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 12, 2018

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Sep 12, 2018

Member

@sttts I've updated it. But do we need to change the nil in workqueue.Parallelize to the default context.TODO()

ParallelizeUntil(nil, workers, pieces, doWorkPiece)

Member

wgliang commented Sep 12, 2018

@sttts I've updated it. But do we need to change the nil in workqueue.Parallelize to the default context.TODO()

ParallelizeUntil(nil, workers, pieces, doWorkPiece)

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Sep 12, 2018

Member

/retest

Member

wgliang commented Sep 12, 2018

/retest

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Oct 4, 2018

Member

/ping @sttts
for approve

Member

wgliang commented Oct 4, 2018

/ping @sttts
for approve

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Oct 5, 2018

Member

/retest

Member

wgliang commented Oct 5, 2018

/retest

@yastij

yastij approved these changes Oct 6, 2018

/lgtm

Thanks @wgliang !

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 6, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 6, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wgliang, wojtek-t, yastij, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wgliang, wojtek-t, yastij, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Oct 6, 2018

Member

/retest

Member

wgliang commented Oct 6, 2018

/retest

@wgliang

This comment has been minimized.

Show comment
Hide comment
@wgliang

wgliang Oct 6, 2018

Member

/retest

Member

wgliang commented Oct 6, 2018

/retest

@fejta-bot

This comment has been minimized.

Show comment
Hide comment
@fejta-bot

fejta-bot Oct 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Oct 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit c00f19b into kubernetes:master Oct 6, 2018

18 checks passed

cla/linuxfoundation wgliang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment