Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scheduler crash when Prioritize Map function failed #68563

Merged
merged 1 commit into from
Sep 27, 2018
Merged

fix scheduler crash when Prioritize Map function failed #68563

merged 1 commit into from
Sep 27, 2018

Conversation

DylanBLE
Copy link
Contributor

@DylanBLE DylanBLE commented Sep 12, 2018 •
edited
Loading

What this PR does / why we need it:
Fix a bug causing scheduler crash

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68561

Special notes for your reviewer:

Release note:

Fix scheduler crashes when Prioritize Map function returns error.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2018
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 12, 2018
@DylanBLE
Copy link
Contributor Author

/assign sig-scheduling-maintainers

@k8s-ci-robot
Copy link
Contributor

@DylanBLE: GitHub didn't allow me to assign the following users: sig-scheduling-maintainers.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign sig-scheduling-maintainers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DylanBLE
Copy link
Contributor Author

/assign @ravisantoshgudimetla

@neolit123
Copy link
Member

/kind bug
/ok-to-test

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 12, 2018
@neolit123
Copy link
Member

@DylanBLE could you please add a release note explaining your bug fix.

@k82cn
Copy link
Member

k82cn commented Sep 13, 2018

@kubernetes/sig-scheduling-pr-reviews

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 13, 2018
@DylanBLE
Copy link
Contributor Author

/retest

@DylanBLE
Copy link
Contributor Author

/retest

1 similar comment
@DylanBLE
Copy link
Contributor Author

/retest

Huang-Wei
Huang-Wei reviewed Sep 14, 2018
View reviewed changes
pkg/scheduler/core/generic_scheduler_test.go Outdated
return schedulerapi.HostPriority{}, errPrioritize
}

func getNodeRequcePriority(pod *v1.Pod, meta interface{}, nodeNameToInfo map[string]*schedulercache.NodeInfo, result schedulerapi.HostPriorityList) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getNodeReducePriority

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@DylanBLE
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

Huang-Wei
Huang-Wei approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cc @bsalamat for another look.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@DylanBLE
Copy link
Contributor Author

/retest

bsalamat
bsalamat approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, DylanBLE, Huang-Wei, ravisantoshgudimetla, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DylanBLE
Copy link
Contributor Author

@bsalamat Could you please remove the /hold label and add a milestone for v1.12? Thanks.

@k82cn
Copy link
Member

k82cn commented Sep 27, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2018
@k82cn
Copy link
Member

k82cn commented Sep 27, 2018

add a milestone for v1.12

Please create another cherry pick PR for 1.12; it will be included in 1.12.1. IMO, we should cherry pick this to avoid crash.

@DylanBLE
Copy link
Contributor Author

/test pull-kubernetes-integration

@DylanBLE DylanBLE mentioned this pull request Sep 27, 2018
Merged
@k8s-ci-robot
Copy link
Contributor

@DylanBLE: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws f33c2c1 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-integration f33c2c1 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit a6bc5aa into kubernetes:master Sep 27, 2018
k8s-ci-robot added a commit that referenced this pull request Sep 30, 2018
@k8s-ci-robot
Merge pull request #69135 from DylanBLE/dev
b6ea286 
Automated cherry pick of #68563: fix scheduler crash when Prioritize Map function failed
@ravisantoshgudimetla ravisantoshgudimetla mentioned this pull request Oct 8, 2018
Merged
@DylanBLE DylanBLE mentioned this pull request Oct 10, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 19, 2018
@k8s-ci-robot
Merge pull request #69618 from DylanBLE/1.11-rebase
d746d06 
Automated cherry pick of #68563: fix scheduler crash when Prioritize Map function failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei approved these changes

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

@yastij yastij yastij approved these changes

@bsalamat bsalamat bsalamat approved these changes

@resouer resouer Awaiting requested review from resouer

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@Huang-Wei Huang-Wei

@yastij yastij

@ravisantoshgudimetla ravisantoshgudimetla

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure of Priority function causes Scheduler Crash
8 participants
@DylanBLE @k8s-ci-robot @neolit123 @k82cn @ravisantoshgudimetla @Huang-Wei @yastij @bsalamat