Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #68563: fix scheduler crash when Prioritize Map function failed #69618

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Automated cherry pick of #68563: fix scheduler crash when Prioritize Map function failed #69618

merged 1 commit into from
Oct 19, 2018

Conversation

DylanBLE
Copy link
Contributor

Cherry pick of #68563 on release-1.11.

#68563: fix scheduler crash when Prioritize Map function failed

Release note:

Fix scheduler crashes when Prioritize Map function returns error.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 10, 2018
@DylanBLE
Copy link
Contributor Author

/assign ravisantoshgudimetla
@ravisantoshgudimetla

@DylanBLE DylanBLE mentioned this pull request Oct 10, 2018
Merged
@DylanBLE
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2018
@k82cn
Copy link
Member

k82cn commented Oct 10, 2018

/ok-to-test
/kind bug
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DylanBLE, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2018
ravisantoshgudimetla
ravisantoshgudimetla approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DylanBLE.
/lgtm

@ravisantoshgudimetla
Copy link
Contributor

/cc @foxish for cherry-pick approval.

@k82cn
Copy link
Member

k82cn commented Oct 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2018
@DylanBLE
Copy link
Contributor Author

/assign @foxish

@foxish foxish added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 19, 2018
@foxish foxish removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 19, 2018
@foxish foxish added this to the v1.11 milestone Oct 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit d746d06 into kubernetes:release-1.11 Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@foxish foxish

@ravisantoshgudimetla ravisantoshgudimetla

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DylanBLE @k82cn @k8s-ci-robot @ravisantoshgudimetla @foxish