Fix chown on distributed flex volumes (like gluster) #68680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/storage
pkg/volume/flexvolume/driver-call.go
Outdated
| @@ -222,12 +222,14 @@ type DriverStatus struct { | |||
| type DriverCapabilities struct { | |||
| Attach bool `json:"attach"` | |||
| SELinuxRelabel bool `json:"selinuxRelabel"` | |||
| SupportsFSGroup bool `json:"supportsFSGroup"` | |||
There was a problem hiding this comment.
Lets call this just FSGroup, similar to SELinuxRelabel & Attach.
There was a problem hiding this comment.
@chakri-nelluri fixed
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
k8s-ci-robot
added
size/XS
|
/retest |
|
Can you please add a release note to the PR? |
|
Yes. Could you run again tests. I fixed comment |
pkg/volume/flexvolume/driver-call.go
Outdated
| @@ -222,12 +222,14 @@ type DriverStatus struct { | |||
| type DriverCapabilities struct { | |||
| Attach bool `json:"attach"` | |||
| SELinuxRelabel bool `json:"selinuxRelabel"` | |||
| FSGroup bool `json:"fSGroup"` | |||
There was a problem hiding this comment.
*Nit - Please make it "fsGroup"
There was a problem hiding this comment.
@chakri-nelluri ok thanks, fixed
k8s-ci-robot
added
release-note
|
@gnufied release notes added |
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
/lgtm |
k8s-ci-robot
added
lgtm
|
putting this one hold. So as @chakri-nelluri can have a final look before it merges. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
chakri-nelluri
approved these changes
Sep 17, 2018
|
/lgtm |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
LGTM, but holding this for 1.13 |
k8s-ci-robot
removed
the
lgtm
|
FYI I rebased code due to conflicts after some other PRs have been merged |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benoitf, chakri-nelluri, gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
benoitf
added a commit
to benoitf/gluster-subvol
that referenced
this pull request
Sep 27, 2018
With this patch it's possible to disable fsGroup kubernetes/kubernetes#68680 it is also merged on OKD openshift/origin#21070 3.11.x Fix gluster#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FlexVolume mount operation is performing by default the change of volume ownership when fsGroup is provided.
The problem is that when performing that on distributed volumes like a gluster volume, when mounting the volume into a pod, there is big
chownoperation running on all files on this volume.For example, as we may always get the same volume for the same user, k8s is trying to perform a lot of
chownoperations . If there are few files on the volume it’s immediate but with like 5K files, etc it takes a huge timeWith the provided patch, the driver capability
fsGroup:falsewould skip that.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #68137
Release note:
/sig-storage