Fix DS tests to set node selectors related annotations on test namespaces to empty.

[aveshagarwal]

Conformance tests have a higher bar than regular e2e tests and should work on as diverse a set of clusters as possible. If the alpha scheduling admission plugin is on to restrict the set of node labels a pod can target is on, scheduling conformance tests fail.

Scheduling conformance tests related to daemonsets should set the annotation that relaxes node selection restrictions, if any are set. This ensures conformance tests can run on a wider array of clusters.

@smarterclayton @sjenning @kubernetes/sig-apps-pr-reviews @kubernetes/sig-scheduling-pr-reviews

[smarterclayton]

As conformance tests, the scheduler tests need to be extra sensitive to kubernetes clusters that may impose scheduling restrictions. Since PodNodeSelector is in fairly wide use, this change allows those clusters leveraging it to remain compliant without changing the semantics of the test.

[neolit123]

/kind bug

[smarterclayton]

This will need to be back ported to 1.10 at the least, although it's not critical that we deliver pre 1.12 GA

[smarterclayton]

/lgtm

now that 1.13 is open. Let's back port to 1.10, 1.11, and 1.12 so that the conformance tests tolerate this

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/apps/OWNERS [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aveshagarwal]

now that 1.13 is open. Let's back port to 1.10, 1.11, and 1.12 so that the conformance tests tolerate this

I was going through this doc: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md , but its not clear, so should I create cherry-pick PRs manually?

[smarterclayton]

The bot will do it for you, but the release managers for those releases need to be involved and need to match approval.

…

On Mon, Oct 8, 2018 at 2:35 PM Avesh Agarwal ***@***.***> wrote: now that 1.13 is open. Let's back port to 1.10, 1.11, and 1.12 so that the conformance tests tolerate this I was going through this doc: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md , but its not clear, so should I create cherry-pick PRs manually? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#68793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p5sNfy0FfbR36xfM7VQrBiU7WTT8ks5ui5rkgaJpZM4WuYDA> .

[aveshagarwal]

/cherry-pick release-3.12 /cherry-pick release-3.11 /cherry-pick release-3.10 On Mon, Oct 8, 2018 at 3:39 PM Clayton Coleman <notifications@github.com> wrote:

…

The bot will do it for you, but the release managers for those releases need to be involved and need to match approval. On Mon, Oct 8, 2018 at 2:35 PM Avesh Agarwal ***@***.***> wrote: > now that 1.13 is open. Let's back port to 1.10, 1.11, and 1.12 so that the > conformance tests tolerate this > > I was going through this doc: > https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md > , but its not clear, so should I create cherry-pick PRs manually? > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > < #68793 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/ABG_p5sNfy0FfbR36xfM7VQrBiU7WTT8ks5ui5rkgaJpZM4WuYDA > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#68793 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADbgfLN48j3dxv7iGU8zGCwngu9M7qWOks5ui6oJgaJpZM4WuYDA> .

[aveshagarwal]

@feiskyer for 1.12
@foxish for 1.11
@MaciekPytel for 1.10

to have this PR cherry-picked in 1.12/11/10

[smarterclayton]

I updated the description and release note of this PR with more data about why this needs a back port.

[feiskyer]

@aveshagarwal Please create cherry pick PRs for each branch