Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Kubeadm remove v1alpha2 api #69055
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
This PR leaves some TODOs as a placeholder for implementing v1alpha3-->v1beta1 roundtrip tests in following PRs.
This was referenced
Sep 25, 2018
Please address the comment, or possibly follow up on a separate PR.
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Is the goal here to have one alpha version and n beta versions?
Seems like removing the v1alpha2 type is just as dangerous as making a breaking change to v1alpha1 like in the 1.10 release. It feels like at this point we'd want to rename v1alpha2 to v1alpha1 and v1alpha3 to v1beta1.
@chuckha - It's explicitly stated that the support model for kubeadm needs to upgrade through. So a 1.11 version can only upgrade from 1.10. Maintaining code and machinery of past versions (that aren't supported) is an albatross so we continually shed the code every cycle.
i know that removing v1alpha1 early in the 1.12 cycle broke kubernetes-anywhere because
this early removal method, forced us to handle versions in bash, which is a bad outcome:
i will send a PR for k-a, because i'm pretty sure this PR will make the master tests red.
Current version is v1alpha3; this PR is getting rid of v1alpha2
Thanks. We can make k/a use v1alpha3 for kubeadm v>=1.12