Add fallbacks for getting node IP from Azure IMDS #69077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
|
/kind bug |
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 28, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 28, 2018
…77-upstream-release-1.9 Automated cherry pick of #69077: Add fallbacks for getting node IP from Azure IMDS
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 28, 2018
…77-upstream-release-1.12 Automated cherry pick of #69077: Add fallbacks for getting node IP from Azure IMDS
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 2, 2018
…77-upstream-release-1.10 Automated cherry pick of #69077: Add fallbacks for getting node IP from Azure IMDS
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 19, 2018
…77-upstream-release-1.11 Automated cherry pick of #69077: Add fallbacks for getting node IP from Azure IMDS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The internal IP address is got from instance metadata, but it is empty sometimes. This PR adds fallbacks to ARM API, so that the IP could be ensured non empty.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #69075
Special notes for your reviewer:
Should cherry pick to all old releases.
Release note: