Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dry-run output in kubectl apply --prune #69344

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Fix dry-run output in kubectl apply --prune #69344

merged 2 commits into from
Nov 14, 2018

Commits on Nov 11, 2018

  1. Fix dry-run output in kubectl apply --prune 

    Makes dry-run output match what would happen when running in non dry-run mode.

Objects would only get added to visitedUids if running in non dry-run mode.

visitedUids is used by prune() to know if an action should be taked on the item or not.

Fixes kubernetes#67863
    @zegl
    zegl committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    74e63c8 View commit details
    Browse the repository at this point in the history

  2. Fix the TestRunApplyPrintsValidObjectList test 

    The fake webclient should return one ConfigMap per request, not the whole ConfigMapList

Also added additional tests to the output
    @zegl
    zegl committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    37c253a View commit details
    Browse the repository at this point in the history