-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dry-run output in kubectl apply --prune #69344
Fix dry-run output in kubectl apply --prune #69344
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test |
c7a620b
to
2685967
Compare
/retest |
2685967
to
1cf8830
Compare
1cf8830
to
5c8ef1c
Compare
/retest |
1 similar comment
/retest |
/test pull-kubernetes-integration |
/test pull-kubernetes-e2e-gce-100-performance |
5c8ef1c
to
c468737
Compare
Rebased to resolve conflicts (in |
c468737
to
8193059
Compare
What do I have to do to get this reviewed? |
@zegl sorry that it's taking time to get this reviewed! /kind bug |
cc @apelisse |
Makes dry-run output match what would happen when running in non dry-run mode. Objects would only get added to visitedUids if running in non dry-run mode. visitedUids is used by prune() to know if an action should be taked on the item or not. Fixes kubernetes#67863
The fake webclient should return one ConfigMap per request, not the whole ConfigMapList Also added additional tests to the output
8193059
to
37c253a
Compare
Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, zegl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.13 |
What this PR does / why we need it:
Makes dry-run output match what would happen when running in non dry-run mode.
Objects would only get added to visitedUids if running in non dry-run mode.
visitedUids is used by prune() to know if an action should be taked on the item or not.
Which issue(s) this PR fixes :
Fixes #67863
Special notes for your reviewer:
Release note: