New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go1.11.1 #69386

Merged
merged 10 commits into from Oct 6, 2018

Conversation

@cblecker
Member

cblecker commented Oct 3, 2018

What this PR does / why we need it:
Updates kubernetes to build under go1.11.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #67872

Special notes for your reviewer:
Will need CI images/environments to be bumped too, as there are gofmt changes.

Release note:

Update to use go1.11.1

/assign @ixdy @BenTheElder
/cc @dims @kubernetes/sig-release-misc @kubernetes/sig-scalability-misc

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 3, 2018

Member

oh, also cc: @kubernetes/sig-testing regarding CI bumps

Member

cblecker commented Oct 3, 2018

oh, also cc: @kubernetes/sig-testing regarding CI bumps

@cblecker cblecker referenced this pull request Oct 3, 2018

Closed

Update to go1.11 #67872

@AishSundar

This comment has been minimized.

Show comment
Hide comment
@AishSundar

AishSundar Oct 3, 2018

Contributor

/milestone v1.13

Contributor

AishSundar commented Oct 3, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 3, 2018

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Oct 5, 2018

Member

also

/lgtm

Member

lavalamp commented Oct 5, 2018

also

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 5, 2018

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Oct 5, 2018

Member

/retest

Member

BenTheElder commented Oct 5, 2018

/retest

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Oct 5, 2018

Member

/hold cancel

I guess that wasn't really necessary.

Member

lavalamp commented Oct 5, 2018

/hold cancel

I guess that wasn't really necessary.

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Oct 5, 2018

Member

I sent a heads-up to the kubernetes-dev mailing list, since this will be disruptive.

Member

lavalamp commented Oct 5, 2018

I sent a heads-up to the kubernetes-dev mailing list, since this will be disruptive.

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Oct 5, 2018

Member

I think integration may have flaked, but that's kinda to be expected with integration lately :/

Member

BenTheElder commented Oct 5, 2018

I think integration may have flaked, but that's kinda to be expected with integration lately :/

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Oct 5, 2018

Member

/retest

Member

BenTheElder commented Oct 5, 2018

/retest

@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Oct 5, 2018

Member

@cblecker @BenTheElder looks like an actual go vet failure.

Fix asap, merge while broken & quick follow-up, or abandon ship?

Member

lavalamp commented Oct 5, 2018

@cblecker @BenTheElder looks like an actual go vet failure.

Fix asap, merge while broken & quick follow-up, or abandon ship?

cblecker added some commits Oct 5, 2018

fix vet error in pkg/controller/route/route_controller_test.go
pkg/controller/route/route_controller_test.go:101: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:102: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:105: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:106: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:118: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:121: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:122: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:135: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:136: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:148: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:149: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:150: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:151: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:154: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:155: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:167: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:168: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:171: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:172: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:185: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:197: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:198: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:199: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:202: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:203: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:215: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:216: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:217: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:220: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:221: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
pkg/controller/route/route_controller_test.go:222: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields
fix vet error in pkg/kubelet/kubelet_test.go
pkg/kubelet/kubelet_test.go:1573: *k8s.io/kubernetes/pkg/kubelet/container/testing.FakePod composite literal uses unkeyed fields
@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Oct 5, 2018

Member

fix asap, if we abandon ship and go back to go1.10 more of these will be introduced, these are recent changes in master that don't work for 1.11

Member

BenTheElder commented Oct 5, 2018

fix asap, if we abandon ship and go back to go1.10 more of these will be introduced, these are recent changes in master that don't work for 1.11

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Oct 5, 2018

Member

they also look like very trivial fixes hopefully. they're all in our code, and they're small stuff like printf mistakes

Member

BenTheElder commented Oct 5, 2018

they also look like very trivial fixes hopefully. they're all in our code, and they're small stuff like printf mistakes

fix vet error in plugin/pkg/admission/storage/persistentvolume/label/…
…admission.go

plugin/pkg/admission/storage/persistentvolume/label/admission.go:173: Verbose.Info call has possible formatting directive %v
@lavalamp

This comment has been minimized.

Show comment
Hide comment
@lavalamp

lavalamp Oct 5, 2018

Member

OK, we'll wait for a fix in this PR then :)

Member

lavalamp commented Oct 5, 2018

OK, we'll wait for a fix in this PR then :)

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 5, 2018

cblecker added some commits Oct 5, 2018

fix vet error in test/soak/cauldron/cauldron.go
test/soak/cauldron/cauldron.go:106: Warningf format %e has arg ns of wrong type string
fix vet error in test/soak/serve_hostnames/serve_hostnames.go
test/soak/serve_hostnames/serve_hostnames.go:124: Warningf format %e has arg ns of wrong type string

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 5, 2018

@BenTheElder

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 5, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f17e9a into kubernetes:master Oct 6, 2018

17 of 18 checks passed

pull-kubernetes-local-e2e-containerized Job triggered.
Details
cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:go-1.11 branch Oct 6, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 6, 2018

Contributor

@cblecker: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized ee3e404 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Oct 6, 2018

@cblecker: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized ee3e404 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment