Update to go1.11.1 #69386

cblecker · 2018-10-03T17:55:28Z

What this PR does / why we need it:
Updates kubernetes to build under go1.11.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #67872

Special notes for your reviewer:
Will need CI images/environments to be bumped too, as there are gofmt changes.

Release note:

Update to use go1.11.1

/assign @ixdy @BenTheElder
/cc @dims @kubernetes/sig-release-misc @kubernetes/sig-scalability-misc

cblecker · 2018-10-03T17:57:42Z

oh, also cc: @kubernetes/sig-testing regarding CI bumps

AishSundar · 2018-10-03T18:23:36Z

/milestone v1.13

BenTheElder · 2018-10-05T21:41:23Z

/retest

lavalamp · 2018-10-05T21:51:22Z

/hold cancel

I guess that wasn't really necessary.

lavalamp · 2018-10-05T21:56:52Z

I sent a heads-up to the kubernetes-dev mailing list, since this will be disruptive.

BenTheElder · 2018-10-05T22:07:00Z

I think integration may have flaked, but that's kinda to be expected with integration lately :/

BenTheElder · 2018-10-05T22:07:40Z

/retest

lavalamp · 2018-10-05T22:47:46Z

@cblecker @BenTheElder looks like an actual go vet failure.

Fix asap, merge while broken & quick follow-up, or abandon ship?

pkg/controller/route/route_controller_test.go:101: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:102: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:105: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:106: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:118: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:121: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:122: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:135: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:136: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:148: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:149: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:150: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:151: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:154: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:155: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:167: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:168: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:171: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:172: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:185: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:197: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:198: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:199: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:202: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:203: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:215: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:216: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:217: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:220: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:221: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields pkg/controller/route/route_controller_test.go:222: *k8s.io/kubernetes/vendor/k8s.io/cloud-provider.Route composite literal uses unkeyed fields

pkg/kubelet/kubelet_test.go:1573: *k8s.io/kubernetes/pkg/kubelet/container/testing.FakePod composite literal uses unkeyed fields

BenTheElder · 2018-10-05T22:53:35Z

fix asap, if we abandon ship and go back to go1.10 more of these will be introduced, these are recent changes in master that don't work for 1.11

BenTheElder · 2018-10-05T22:54:20Z

they also look like very trivial fixes hopefully. they're all in our code, and they're small stuff like printf mistakes

…admission.go plugin/pkg/admission/storage/persistentvolume/label/admission.go:173: Verbose.Info call has possible formatting directive %v

lavalamp · 2018-10-05T22:58:00Z

OK, we'll wait for a fix in this PR then :)

BenTheElder · 2018-10-05T23:01:54Z

test/soak/serve_hostnames/serve_hostnames.go

@@ -116,12 +116,12 @@ func main() {
 	// Create the namespace
 	got, err := client.CoreV1().Namespaces().Create(&v1.Namespace{ObjectMeta: metav1.ObjectMeta{GenerateName: "serve-hostnames-"}})
 	if err != nil {
-		glog.Fatalf("Failed to create namespace: %v", err)
+		glog.Fatalf("Failed to create namespace: %e", err)


this doesn't seem right?

test/soak/cauldron/cauldron.go:106: Warningf format %e has arg ns of wrong type string

test/soak/serve_hostnames/serve_hostnames.go:124: Warningf format %e has arg ns of wrong type string

BenTheElder

/lgtm

k8s-ci-robot · 2018-10-05T23:13:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [cblecker,lavalamp]
~~cluster/OWNERS~~ [lavalamp]
~~cmd/cloud-controller-manager/OWNERS~~ [lavalamp]
~~cmd/kube-apiserver/OWNERS~~ [lavalamp]
~~cmd/kubeadm/OWNERS~~ [lavalamp]
~~hack/OWNERS~~ [cblecker,lavalamp]
~~pkg/OWNERS~~ [lavalamp]
~~plugin/pkg/admission/OWNERS~~ [lavalamp]
~~staging/src/k8s.io/api/OWNERS~~ [lavalamp]
~~staging/src/k8s.io/apimachinery/pkg/OWNERS~~ [lavalamp]
~~staging/src/k8s.io/apiserver/OWNERS~~ [lavalamp]
~~staging/src/k8s.io/client-go/OWNERS~~ [lavalamp]
~~staging/src/k8s.io/code-generator/OWNERS~~ [lavalamp]
~~staging/src/k8s.io/kube-aggregator/OWNERS~~ [lavalamp]
~~test/OWNERS~~ [cblecker,lavalamp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2018-10-06T01:08:30Z

@cblecker: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-local-e2e-containerized	`ee3e404`	link	`/test pull-kubernetes-local-e2e-containerized`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 3, 2018

k8s-ci-robot assigned BenTheElder and ixdy Oct 3, 2018

k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 3, 2018

k8s-ci-robot requested a review from dims October 3, 2018 17:55

cblecker mentioned this pull request Oct 3, 2018

Update to go1.11 #67872

Closed

k8s-ci-robot added this to the v1.13 milestone Oct 3, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2018

cblecker added 2 commits October 5, 2018 15:48

fix vet error in pkg/kubelet/kubelet_test.go

0d63b55

pkg/kubelet/kubelet_test.go:1573: *k8s.io/kubernetes/pkg/kubelet/container/testing.FakePod composite literal uses unkeyed fields

fix vet error in plugin/pkg/admission/storage/persistentvolume/label/…

563734f

…admission.go plugin/pkg/admission/storage/persistentvolume/label/admission.go:173: Verbose.Info call has possible formatting directive %v

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2018

BenTheElder reviewed Oct 5, 2018

View reviewed changes

cblecker added 2 commits October 5, 2018 16:04

fix vet error in test/soak/cauldron/cauldron.go

781d3f6

test/soak/cauldron/cauldron.go:106: Warningf format %e has arg ns of wrong type string

fix vet error in test/soak/serve_hostnames/serve_hostnames.go

ee3e404

test/soak/serve_hostnames/serve_hostnames.go:124: Warningf format %e has arg ns of wrong type string

cblecker force-pushed the go-1.11 branch from 098c075 to ee3e404 Compare October 5, 2018 23:06

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2018

BenTheElder approved these changes Oct 5, 2018

View reviewed changes

k8s-ci-robot merged commit 0f17e9a into kubernetes:master Oct 6, 2018

cblecker deleted the go-1.11 branch October 6, 2018 00:36

This was referenced Oct 6, 2018

travis: bump go version to 1.11.1 kubernetes/client-go#481

Merged

Bump default go version to 1.11.1 kubernetes/publishing-bot#120

Merged

liggitt mentioned this pull request Dec 3, 2018

Add external dependencies section to release notes kubernetes/sig-release#398

Merged

rf232 mentioned this pull request Jan 4, 2019

Update Go versions in development.md kubernetes/community#3066

Merged

ixdy mentioned this pull request Feb 22, 2019

Update release-1.11 branch to go1.11.5 #74430

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to go1.11.1 #69386

Update to go1.11.1 #69386

cblecker commented Oct 3, 2018

cblecker commented Oct 3, 2018

AishSundar commented Oct 3, 2018

BenTheElder commented Oct 5, 2018

lavalamp commented Oct 5, 2018

lavalamp commented Oct 5, 2018

BenTheElder commented Oct 5, 2018

BenTheElder commented Oct 5, 2018

lavalamp commented Oct 5, 2018

BenTheElder commented Oct 5, 2018

BenTheElder commented Oct 5, 2018

lavalamp commented Oct 5, 2018

BenTheElder Oct 5, 2018

BenTheElder left a comment

k8s-ci-robot commented Oct 5, 2018

k8s-ci-robot commented Oct 6, 2018

Update to go1.11.1 #69386

Update to go1.11.1 #69386

Conversation

cblecker commented Oct 3, 2018

cblecker commented Oct 3, 2018

AishSundar commented Oct 3, 2018

BenTheElder commented Oct 5, 2018

lavalamp commented Oct 5, 2018

lavalamp commented Oct 5, 2018

BenTheElder commented Oct 5, 2018

BenTheElder commented Oct 5, 2018

lavalamp commented Oct 5, 2018

BenTheElder commented Oct 5, 2018

BenTheElder commented Oct 5, 2018

lavalamp commented Oct 5, 2018

BenTheElder Oct 5, 2018

Choose a reason for hiding this comment

BenTheElder left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 5, 2018

k8s-ci-robot commented Oct 6, 2018