-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use etcd endpoints from advertise-client-urls #69827
Conversation
It makes more sense to use advertised etcd endpoints instead of using listened client URLS. I'm solving this use case: Listen on localhost and public IP but I don't want to add multiple endpoints to kube-apiservers because it's targeting same etcd server.
@tomkukral /kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, unless we had a good reason to not use advertise-client-urls in the first place?
Is there anything I can do to merge this PR? |
/assign @chuckha @fabriziopandini |
we are just overwhelmed with other tasks near the end of the release cycle. |
This makes sense to me, thanks for the patch! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timothysc, tomkukral The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-kops-aws |
/test pull-kubernetes-e2e-gce-100-performance |
It makes more sense to use advertised etcd endpoints instead of using
listened client URLS.
What this PR does / why we need it:
I'm solving this case: Listen on localhost and public IP but I don't
want to add multiple endpoints to kube-apiservers because it's targeting
same etcd server.
Special notes for your reviewer:
Release note: