New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network stats for Windows containers #69920
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: feiskyer If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kindly ping @yujuhong. Could you take a look at this PR for the alternative way to get windows network stats? |
I've talked to a few folks, and they have expressed concerns about adding network stats methods in CRI that would only be used on Windows. As we spoke earlier on slack, can we get a PoC to see how it'd look like to get the information directly in kubelet (without going through CRI) to help us evaluate the best way to approach this? Thanks. |
Opened #70121 instead. |
per discussion in sig-arch, let's move this out to 1.14 /milestone v1.14 |
Close in favor of #70121. |
What this PR does / why we need it:
An alternative way for #67884.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #64901
Special notes for your reviewer:
Refer #67884 (comment).
Release note:
/assign @yujuhong @PatrickLang