Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network stats for Windows containers #69920

Closed
wants to merge 5 commits into from

Conversation

feiskyer
Copy link
Member

What this PR does / why we need it:

An alternative way for #67884.

  • To get node network stats, it invokes 'Get-NetAdapterStatistics | ConvertTo-Json' to fetch all adapters statistics
  • To get pod stats, it adds ListPodSandboxStats in CRI and implementation in dockershim (only windows).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64901

Special notes for your reviewer:

Refer #67884 (comment).

Release note:

Add network stats for Windows nodes and pods.

/assign @yujuhong @PatrickLang

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 17, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 17, 2018
@feiskyer feiskyer added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Oct 17, 2018
@k8s-ci-robot k8s-ci-robot removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: feiskyer
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tallclair

If they are not already assigned, you can assign the PR to them by writing /assign @tallclair in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member Author

Kindly ping @yujuhong. Could you take a look at this PR for the alternative way to get windows network stats?

@yujuhong
Copy link
Contributor

I've talked to a few folks, and they have expressed concerns about adding network stats methods in CRI that would only be used on Windows. As we spoke earlier on slack, can we get a PoC to see how it'd look like to get the information directly in kubelet (without going through CRI) to help us evaluate the best way to approach this? Thanks.

@feiskyer
Copy link
Member Author

@yujuhong Thanks. Opened #70121. PTAL

@feiskyer
Copy link
Member Author

Opened #70121 instead.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2018
@dims
Copy link
Member

dims commented Nov 15, 2018

per discussion in sig-arch, let's move this out to 1.14

/milestone v1.14

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.13, v1.14 Nov 15, 2018
@PatrickLang PatrickLang added this to In Review in SIG-Windows Jan 11, 2019
@feiskyer
Copy link
Member Author

Close in favor of #70121.

@feiskyer feiskyer closed this Jan 18, 2019
@PatrickLang PatrickLang moved this from In Review to Done (v.1.14) in SIG-Windows Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add network stats for Windows containers
5 participants