Add network stats for Windows containers

[feiskyer]

What this PR does / why we need it:

An alternative way for #67884 and #69920.

• To get node network stats, it invokes 'Get-NetAdapterStatistics | ConvertTo-Json' to fetch all adapters statistics
• To get pod stats, it invokes hcsshim directly to fetch container's network statistics.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64901

Special notes for your reviewer:

Refer #67884 (comment).

Release note:

Add network stats for Windows nodes and pods.

/assign @yujuhong @PatrickLang
/milestone v1.13
/sig windows

[feiskyer]

/kind bug

[feiskyer]

/cc @dineshgovindasamy

[feiskyer]

/test pull-kubernetes-verify

[feiskyer]

/retest

[dineshgovindasamy]

Thanks Pengfei. PR looks good.
/lgtm

[feiskyer]

/test pull-kubernetes-integration

[feiskyer]

ping @yujuhong Could you have a look at this?

[feiskyer]

ping @yujuhong

[benmoss]

This all seems reasonable to me. The cri_stats_provider.go code seems like it might benefit from a higher abstraction, since it's now weaving between the Linux-only cadvisor calls and the Windows-only listContainerNetworkStats call, but I'm not sure that needs to happen now.

[feiskyer]

The cri_stats_provider.go code seems like it might benefit from a higher abstraction, since it's now weaving between the Linux-only cadvisor calls and the Windows-only listContainerNetworkStats call, but I'm not sure that needs to happen now.

The best way I think is abstracting the windows features also under cadvisor interface, but that's not possible yet because there's no enough information from hcsshim (which means CRI interface should be changed to fetch them).

And there is also another impl #69920 for this feature which I think is cleaner, but that requires changes of CRI.

[feiskyer]

Rebased and conflicts solved.

[feiskyer]

ping @yujuhong @derekwaynecarr Help to take at the PR again?

[yujuhong]

Looks good mostly with some comments.

[yujuhong]

/cc @pjh FYI

[k8s-ci-robot]

@yujuhong: GitHub didn't allow me to request PR reviews from the following users: pjh, FYI.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pjh FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feiskyer]

@yujuhong Addressed comments. PTAL

[feiskyer]

/retest

[yujuhong]

@feiskyer does the existing summary API test check for this, and does the test pass after the change?
Since there is no presubmit testing yet, I'd like to make sure the features added will be tested.

[feiskyer]

The test covers some, but not all of this, because of invoking powershell commands. We may figure out how to mock powershell later.

[feiskyer]

/retest

[yujuhong]

The test covers some, but not all of this, because of invoking powershell commands. We may figure out how to mock powershell later.

Actually I was talking about e2e tests, but having unit test is good too. We need something to prevent regression. I'm slightly uncomfortable that we can't run node e2e on windows since summary API test is also there.
Can you file a bug to add test coverage for stats in general?

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [yujuhong]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@feiskyer: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-local-e2e-containerized	9cf38de	link	/test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jterry75]

@kevpar - FYI - You should look at this to match CRI stats