Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject unbounded cpu and memory pods if quota is restricting it #7003

Merged
merged 1 commit into from
Apr 22, 2015

Conversation

derekwaynecarr
Copy link
Member

If a quota is enforcing a hard usage limit on cpu or memory in a Namespace, then we reject any pod whose container is requesting unbounded cpu or memory on a Node.

If a user wants to apply a default cpu or memory usage for each container that has unspecified limits, they can create a LimitRange resource that sets a default.

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/limitrange/v1beta3/limit-range.json#L32

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bgrant0607
Copy link
Member

cc @erictune

@derekwaynecarr
Copy link
Member Author

@vishh - any chance you can get to this today?

@vishh
Copy link
Contributor

vishh commented Apr 22, 2015

Somehow I missed this PR! LGTM.

vishh added a commit that referenced this pull request Apr 22, 2015
Reject unbounded cpu and memory pods if quota is restricting it
@vishh vishh merged commit ee06097 into kubernetes:master Apr 22, 2015
@erictune
Copy link
Member

I think eventual plan is to have 3 resource tiers (set limit -> Tier 1, set request and limit -> Tier 2, set request -> Tier 3).
Either each tier will have its own separate quota, or, there will be separate quotas for "limit" and "request" -- e.g. user eric can create pods with total limits of 10GB ram, and also, he can create pods with total requests of 50GB.

So, I interpret this as "when quota is enabled, nobody has any Tier3 quota". Which seems fine.

@erictune
Copy link
Member

IOW, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants