Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates shared apiserver webhook client #70060

Merged
merged 1 commit into from Oct 23, 2018
Merged

updates shared apiserver webhook client #70060

merged 1 commit into from Oct 23, 2018

Conversation

pbarker
Copy link
Contributor

@pbarker pbarker commented Oct 21, 2018 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Makes the shared apiserver webhook more generic

Special notes for your reviewer:
The shared webhook is being used in #70021. We need a way of creating a generic webhook without using a kubeconfig which is why the InitialBackoff is now exported. If preferred a separate set method could be used. Thanks!

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot
Copy link
Contributor

@pbarker: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 21, 2018
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 21, 2018
@pbarker pbarker mentioned this pull request Oct 21, 2018
Merged
@jbeda
Copy link
Contributor

jbeda commented Oct 21, 2018 •
edited

/ok-to-test
/priority important-soon
/release-note-none

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2018
@jbeda
Copy link
Contributor

jbeda commented Oct 21, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 21, 2018
@kubernetes kubernetes deleted a comment from k8s-ci-robot Oct 21, 2018
@sttts
Copy link
Contributor

sttts commented Oct 22, 2018

/lgtm
/approve

@tallclair
Copy link
Member

tallclair commented Oct 22, 2018 •
edited

Manually labeling due to kubernetes/test-infra#9881
(merging probably still blocked though)

@tallclair tallclair added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pbarker, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pbarker
Copy link
Contributor Author

pbarker commented Oct 22, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9fb4a2a into kubernetes:master Oct 23, 2018
@jennybuckley
Copy link

cc @logicalhan

@pbarker pbarker deleted the audit-webhook branch December 18, 2018 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pbarker @k8s-ci-robot @jbeda @sttts @tallclair @jennybuckley