Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct regexp check in IsNodeUnmanagedByProvider #70135

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Correct regexp check in IsNodeUnmanagedByProvider #70135

merged 1 commit into from
Oct 24, 2018

Conversation

marc-sensenich
Copy link
Contributor

The IsNodeUnmanagedByProviderID function in the Azure Cloud Provider should
return the inverse of regexp.Match in the case of checking the ProviderID

What type of PR is this?

/kind bug

What this PR does / why we need it:

Correctly checks in a VM provisioned by Azure is considered to be an unmanaged node by the cloud provider

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Relates to #70126

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Corrects check for non-Azure managed nodes with the Azure cloud provider

@marc-sensenich
Correct regexp check in IsNodeUnmanagedByProvider
0bcbfca 
The IsNodeUnmanagedByProviderID function in the Azure Cloud Provider should
return the inverse of regexp.Match in the case of checking the ProviderID
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2018
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 23, 2018
@marc-sensenich
Copy link
Contributor Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 23, 2018
@marc-sensenich
Copy link
Contributor Author

@feiskyer I'm thinking you may be the best assignee for this since the affected code in this PR was part of the work from #67984

/assign feiskyer

@yastij
Copy link
Member

yastij commented Oct 23, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2018
yastij
yastij approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feiskyer to you for review/approval

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/azure labels Oct 23, 2018
@yastij
Copy link
Member

yastij commented Oct 23, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Oct 23, 2018
feiskyer
feiskyer reviewed Oct 23, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-sensenich Thanks for the fix.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, marc-sensenich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018
@andyzhangx
Copy link
Member

Release note:

fix unsupported issue for node unmanaged by azure provider

@k8s-ci-robot k8s-ci-robot merged commit 3905fb6 into kubernetes:master Oct 24, 2018
@marc-sensenich marc-sensenich mentioned this pull request Oct 24, 2018
Closed
@marc-sensenich marc-sensenich mentioned this pull request Oct 24, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 1, 2018
@k8s-ci-robot
Merge pull request #70190 from marc-sensenich/automated-cherry-pick-o…
9a2642e 
…f-#70135-upstream-release-1.12

Automated cherry pick of #70135: Correct regexp check in IsNodeUnmanagedByProvider
@marc-sensenich marc-sensenich deleted the gh-70126/azure-is-node-unmanaged-fix branch January 11, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@yastij yastij yastij approved these changes

@karataliu karataliu Awaiting requested review from karataliu

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marc-sensenich @yastij @k8s-ci-robot @andyzhangx @feiskyer