Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
e2e: allow unknown providers with a warning #70141
What type of PR is this?
What this PR does / why we need it:
#68483 unintentionally broke several use cases by tightening the validation of the
Whether that really is the right behavior needs more discussion (and in hindsight it probably isn't). In the meantime we need to restore the previous behavior quickly to get all CI jobs working again.
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This was referenced
Oct 23, 2018
@timothysc At the moment this band-aid is still needed. I prefer to have it in 1.13 with a deprecation announcement, then in 1.14 remove it (and enhance the error handling -
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing