Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-anywhere: use 'local' as provider #9884

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

neolit123
Copy link
Member

post the e2e refactor --provider=kubernetes-anywhere is no longer a valid provider.
we don't want to add "kubernetes-anywhere" to the framework as a NULL provider, thus the alternative is to modify all the jobs to use "local".

ref: kubernetes/kubernetes#70059 (comment)

fixes kubernetes/kubernetes#70058

/area config
/kind bug
/assign @BenTheElder @timothysc
/cc @pohly

@neolit123
Copy link
Member Author

/this-is-fine

Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we don't test the cloud provider integrations in these jobs +1.

/lgtm
/approve

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config kind/bug Categorizes issue or PR as related to a bug. labels Oct 22, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, neolit123, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

@neolit123: dog image

In response to this:

/this-is-fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a22e62a63e8a1c1fea8af17dd3aff844f583237c

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit e9e50f3 into kubernetes:master Oct 22, 2018
@k8s-ci-robot
Copy link
Contributor

@neolit123: Updated the job-config configmap using the following files:

  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key kubeadm-upgrade.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-upgrade.yaml
  • key kubeadm-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-x-on-y.yaml
  • key kubeadm.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm.yaml
  • key bazel-build-test.yaml using file config/jobs/kubernetes/sig-testing/bazel-build-test.yaml

In response to this:

post the e2e refactor --provider=kubernetes-anywhere is no longer a valid provider.
we don't want to add "kubernetes-anywhere" to the framework as a NULL provider, thus the alternative is to modify all the jobs to use "local".

ref: kubernetes/kubernetes#70059 (comment)

fixes kubernetes/kubernetes#70058

/area config
/kind bug
/assign @BenTheElder @timothysc
/cc @pohly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants