New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Azure instance metadata handling #70353

Merged
merged 1 commit into from Oct 29, 2018

Conversation

@feiskyer
Member

feiskyer commented Oct 29, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:
/kind bug

What this PR does / why we need it:

Improve Azure instance metadata handling, which includes

  • Add caches to Azure Instance Metadata
  • Add user-agent: "golang/kubernetes-cloud-provider"
  • Remove the fall back to ARM with empty IP
  • Remove call to "v1/InstanceInfo/FD"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70246

Special notes for your reviewer:

Should cherry pick to all old releases.

Does this PR introduce a user-facing change?:

Improve Azure instance metadata handling by adding caches.

/sig azure
/kind bug

/cc @khenidak @brendandburns @andyzhangx

@feiskyer

This comment has been minimized.

Member

feiskyer commented Oct 29, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 29, 2018

@khenidak

/lgtm

})
}
}
for _, address := range ipAddress.IPV6.IPAddress {

This comment has been minimized.

@khenidak

khenidak Oct 29, 2018

Contributor

thank you for this @feiskyer :-)

This comment has been minimized.

@feiskyer

feiskyer Oct 30, 2018

Member

@khenidak Do you know anyone using IPV6 now?

@khenidak

This comment has been minimized.

Contributor

khenidak commented Oct 29, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, khenidak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a8934ff into kubernetes:master Oct 29, 2018

18 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@feiskyer feiskyer deleted the feiskyer:metadata-cache branch Oct 30, 2018

k8s-ci-robot added a commit that referenced this pull request Nov 5, 2018

Merge pull request #70399 from feiskyer/automated-cherry-pick-of-#70353
…-upstream-release-1.12

Automated cherry pick of #70353: Improve Azure instance metadata handling

k8s-ci-robot added a commit that referenced this pull request Nov 5, 2018

Merge pull request #70402 from feiskyer/automated-cherry-pick-of-#70353
…-upstream-release-1.10

Automated cherry pick of #70353: Improve Azure instance metadata handling
@titilambert

This comment has been minimized.

titilambert commented Nov 7, 2018

Will you backport this commit to 1.11.5 ?

@feiskyer

This comment has been minimized.

Member

feiskyer commented Nov 8, 2018

@titilambert Yep, see #70400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment