Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Azure instance metadata handling #70353

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Improve Azure instance metadata handling #70353

merged 1 commit into from
Oct 29, 2018

Conversation

feiskyer
Copy link
Member

What type of PR is this?

Uncomment only one, leave it on its own line:
/kind bug

What this PR does / why we need it:

Improve Azure instance metadata handling, which includes

  • Add caches to Azure Instance Metadata
  • Add user-agent: "golang/kubernetes-cloud-provider"
  • Remove the fall back to ARM with empty IP
  • Remove call to "v1/InstanceInfo/FD"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70246

Special notes for your reviewer:

Should cherry pick to all old releases.

Does this PR introduce a user-facing change?:

Improve Azure instance metadata handling by adding caches.

/sig azure
/kind bug

/cc @khenidak @brendandburns @andyzhangx

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 29, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/azure size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2018
@feiskyer feiskyer mentioned this pull request Oct 29, 2018
Closed
@feiskyer
Copy link
Member Author

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 29, 2018
khenidak
khenidak approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@khenidak khenidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/cloudprovider/providers/azure/azure_instances.go
})
}
}
for _, address := range ipAddress.IPV6.IPAddress {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this @feiskyer :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khenidak Do you know anyone using IPV6 now?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@khenidak
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, khenidak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a8934ff into kubernetes:master Oct 29, 2018
@feiskyer feiskyer deleted the metadata-cache branch October 30, 2018 02:07
This was referenced Oct 30, 2018
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 5, 2018
@k8s-ci-robot
Merge pull request #70399 from feiskyer/automated-cherry-pick-of-#703…
d05f0e7 
…53-upstream-release-1.12

Automated cherry pick of #70353: Improve Azure instance metadata handling
k8s-ci-robot added a commit that referenced this pull request Nov 5, 2018
@k8s-ci-robot
Merge pull request #70402 from feiskyer/automated-cherry-pick-of-#703…
787933e 
…53-upstream-release-1.10

Automated cherry pick of #70353: Improve Azure instance metadata handling
@titilambert
Copy link

Will you backport this commit to 1.11.5 ?

@feiskyer
Copy link
Member Author

feiskyer commented Nov 8, 2018

@titilambert Yep, see #70400.

This was referenced Nov 20, 2018
Closed
Closed
@David-Green David-Green mentioned this pull request Nov 22, 2018
Closed
k8s-ci-robot added a commit that referenced this pull request Dec 3, 2018
@k8s-ci-robot
Merge pull request #70400 from feiskyer/automated-cherry-pick-of-#703…
99612e5 
…53-upstream-release-1.11

Automated cherry pick of #70353: Improve Azure instance metadata handling
@feiskyer feiskyer mentioned this pull request Dec 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khenidak khenidak khenidak approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Azure: Instance metadata fixes and improvement
4 participants
@feiskyer @khenidak @k8s-ci-robot @titilambert