Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure UltraSSD, StandardSSD disk type support #70477

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 31, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
add azure UltraSSD disk support

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70220

Special notes for your reviewer:
In this PR, added two new parameters in azure disk storage class: diskIopsReadWrite (default: 1200), diskMbpsReadWrite (default: 300) according to https://docs.microsoft.com/en-us/azure/virtual-machines/linux/disks-ultra-ssd.
You may review the second commit for mainly related code change:f1bd292
The first commit is go sdk upgrade.

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: ultrassd
provisioner: kubernetes.io/azure-disk
parameters:
  skuname: UltraSSD_LRS
  kind: managed
  cachingmode: None
  diskIopsReadWrite: "1400"
  diskMbpsReadWrite: "320"

btw, possible values of skuname could be: Standard_LRS, StandardSSD_LRS, Premium_LRS, UltraSSD_LRS

Does this PR introduce a user-facing change?:

NONE

Release note:

add azure UltraSSD disk support

/sig azure

/assign @khenidak @feiskyer
cc @brendandburns

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/azure do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Oct 31, 2018
update Godeps.json

update azure sdk for ultrassd support

update bazel

fix build failure
@andyzhangx andyzhangx force-pushed the azure-ultrassd-sdk branch 3 times, most recently from bdb09f2 to 16256c9 Compare October 31, 2018 10:50
@andyzhangx
Copy link
Member Author

FYI @sylus

update stagin Godeps.json

update godeps license

fix test failure

fix comments
@feiskyer
Copy link
Member

feiskyer commented Nov 1, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@andyzhangx
Copy link
Member Author

@brendandburns @khenidak PTAL
the k8s upstream support for UltraSSD is done with this PR, while UltraSSD feature only supports availability zone without vmss, while our acs-engine could only create availability zone with vmss, so we are looking forward to UltraSSD support on vmss.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@mbohlool
Copy link
Contributor

mbohlool commented Nov 1, 2018

cc @lavalamp

@lavalamp
Copy link
Member

lavalamp commented Nov 1, 2018

/approve

I can't tell if there's a compatibility problem or not, I'll add a hold to make sure it doesn't merge until you see this; do a "/hold cancel" if there isn't a problem.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@andyzhangx
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2018
@feiskyer
Copy link
Member

feiskyer commented Nov 2, 2018

@andyzhangx Seems release notes format is wrong? Could you add a release note for this?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 2, 2018
@andyzhangx
Copy link
Member Author

@feiskyer done, original PR template is missing release notes item.

@k8s-ci-robot k8s-ci-robot merged commit 45550ca into kubernetes:master Nov 2, 2018
@andyzhangx andyzhangx changed the title add azure UltraSSD disk support add azure UltraSSD, StandardSSD disk type support Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add azure UltraSSD disk support
6 participants