New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure UltraSSD, StandardSSD disk type support #70477

Merged
merged 2 commits into from Nov 2, 2018

Conversation

@andyzhangx
Member

andyzhangx commented Oct 31, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
add azure UltraSSD disk support

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70220

Special notes for your reviewer:
In this PR, added two new parameters in azure disk storage class: diskIopsReadWrite (default: 1200), diskMbpsReadWrite (default: 300) according to https://docs.microsoft.com/en-us/azure/virtual-machines/linux/disks-ultra-ssd.
You may review the second commit for mainly related code change:f1bd292
The first commit is go sdk upgrade.

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: ultrassd
provisioner: kubernetes.io/azure-disk
parameters:
  skuname: UltraSSD_LRS
  kind: managed
  cachingmode: None
  diskIopsReadWrite: "1400"
  diskMbpsReadWrite: "320"

btw, possible values of skuname could be: Standard_LRS, StandardSSD_LRS, Premium_LRS, UltraSSD_LRS

Does this PR introduce a user-facing change?:

NONE

Release note:

add azure UltraSSD disk support

/sig azure

/assign @khenidak @feiskyer
cc @brendandburns

upgrade azure sdk to support ultra ssd
update Godeps.json

update azure sdk for ultrassd support

update bazel

fix build failure
@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Oct 31, 2018

FYI @sylus

add ultrassd support
update stagin Godeps.json

update godeps license

fix test failure

fix comments
@feiskyer

This comment has been minimized.

Member

feiskyer commented Nov 1, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 1, 2018

@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Nov 1, 2018

@brendandburns @khenidak PTAL
the k8s upstream support for UltraSSD is done with this PR, while UltraSSD feature only supports availability zone without vmss, while our acs-engine could only create availability zone with vmss, so we are looking forward to UltraSSD support on vmss.

@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Nov 1, 2018

/test pull-kubernetes-kubemark-e2e-gce-big

@mbohlool

This comment has been minimized.

Member

mbohlool commented Nov 1, 2018

@lavalamp

This comment has been minimized.

Member

lavalamp commented Nov 1, 2018

/approve

I can't tell if there's a compatibility problem or not, I'll add a hold to make sure it doesn't merge until you see this; do a "/hold cancel" if there isn't a problem.

/hold

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Nov 2, 2018

/hold cancel

@feiskyer

This comment has been minimized.

Member

feiskyer commented Nov 2, 2018

@andyzhangx Seems release notes format is wrong? Could you add a release note for this?

@andyzhangx

This comment has been minimized.

Member

andyzhangx commented Nov 2, 2018

@feiskyer done, original PR template is missing release notes item.

@k8s-ci-robot k8s-ci-robot merged commit 45550ca into kubernetes:master Nov 2, 2018

18 checks passed

cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@andyzhangx andyzhangx changed the title from add azure UltraSSD disk support to add azure UltraSSD, StandardSSD disk type support Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment