-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add azure UltraSSD, StandardSSD disk type support #70477
Conversation
update Godeps.json update azure sdk for ultrassd support update bazel fix build failure
bdb09f2
to
16256c9
Compare
FYI @sylus |
pkg/cloudprovider/providers/azure/azure_managedDiskController.go
Outdated
Show resolved
Hide resolved
pkg/cloudprovider/providers/azure/azure_managedDiskController.go
Outdated
Show resolved
Hide resolved
update stagin Godeps.json update godeps license fix test failure fix comments
16256c9
to
f1bd292
Compare
/lgtm |
@brendandburns @khenidak PTAL |
/test pull-kubernetes-kubemark-e2e-gce-big |
cc @lavalamp |
/approve I can't tell if there's a compatibility problem or not, I'll add a hold to make sure it doesn't merge until you see this; do a "/hold cancel" if there isn't a problem. /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@andyzhangx Seems release notes format is wrong? Could you add a release note for this? |
@feiskyer done, original PR template is missing release notes item. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add azure UltraSSD disk support
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #70220
Special notes for your reviewer:
In this PR, added two new parameters in azure disk storage class:
diskIopsReadWrite
(default: 1200),diskMbpsReadWrite
(default: 300) according to https://docs.microsoft.com/en-us/azure/virtual-machines/linux/disks-ultra-ssd.You may review the second commit for mainly related code change:f1bd292
The first commit is go sdk upgrade.
btw, possible values of
skuname
could be:Standard_LRS
,StandardSSD_LRS
,Premium_LRS
,UltraSSD_LRS
Does this PR introduce a user-facing change?:
Release note:
/sig azure
/assign @khenidak @feiskyer
cc @brendandburns