-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrub comment from Godeps.json #70687
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cofyc If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @cblecker @dims @tallclair @thockin |
|
FYI, normalize |
agree let's not fully drop comments /hold |
/close |
@cofyc: Closing this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
Remove unnecessary 'Comment' field. This also prevents conflicts (e.g. #65632, #69976) because
godep
may generate different comments on same commit in same repo.godep
usesgit describe --tags <commit>
to generate comment, different git versions or local configs will generate different results (latest git use dynamic abbreviation size by default which depends on repo state). And some repo may tag one commit with multiple names which results in multiple comments (depends on your repo state), e.g.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #70686
Special notes for your reviewer:
Does this PR introduce a user-facing change?: