Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub comment from Godeps.json #70687

Closed
wants to merge 1 commit into from
Closed

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented Nov 6, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Remove unnecessary 'Comment' field. This also prevents conflicts (e.g. #65632, #69976) because godep may generate different comments on same commit in same repo.

godep uses git describe --tags <commit> to generate comment, different git versions or local configs will generate different results (latest git use dynamic abbreviation size by default which depends on repo state). And some repo may tag one commit with multiple names which results in multiple comments (depends on your repo state), e.g.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70686

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cofyc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sttts

If they are not already assigned, you can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2018
@cofyc cofyc mentioned this pull request Nov 6, 2018
@cofyc
Copy link
Member Author

cofyc commented Nov 6, 2018

/assign @cblecker @dims @tallclair @thockin

@cofyc
Copy link
Member Author

cofyc commented Nov 6, 2018

Godeps/Godeps.json is not human-friendly without Comment... probably it is better to keep Comment but normalize it.

@cofyc
Copy link
Member Author

cofyc commented Nov 6, 2018

FYI, normalize Comment field solution: #70692.

@dims
Copy link
Member

dims commented Nov 6, 2018

agree let's not fully drop comments

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2018
@cofyc
Copy link
Member Author

cofyc commented Nov 7, 2018

/close
better to keep comment

@k8s-ci-robot
Copy link
Contributor

@cofyc: Closing this PR.

In response to this:

/close
better to keep comment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Comment field conflicts in Godeps/Godeps.json
6 participants