Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include read access to controllerrevisions for admin/edit/view roles #70699

Merged
merged 1 commit into from Nov 12, 2018
Merged

Include read access to controllerrevisions for admin/edit/view roles #70699

merged 1 commit into from Nov 12, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 6, 2018

What type of PR is this?
/kind bug

What this PR does / why we need it:
Includes permissions required by kubectl rollout

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70697

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes ability for admin/edit/view users to see controller revisions, needed for kubectl rollout commands

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 6, 2018

/priority important-soon
/sig cli
/sig auth
/sig apps

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
This was referenced Nov 6, 2018
Merged
Merged
Merged
Closed
@yastij
Copy link
Member

yastij commented Nov 7, 2018

/retest

@liggitt
Copy link
Member Author

liggitt commented Nov 10, 2018

/assign @enj

@liggitt liggitt added this to the v1.13 milestone Nov 10, 2018
@dims
Copy link
Member

dims commented Nov 12, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 94c5953 into kubernetes:master Nov 12, 2018
@liggitt liggitt deleted the controllerrevisions branch November 14, 2018 00:42
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2018
@k8s-ci-robot
Merge pull request #70702 from liggitt/automated-cherry-pick-of-#7069…
32fd37c 
…9-upstream-release-1.10

Automated cherry pick of #70699: Include read access to controllerrevisions for
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2018
@k8s-ci-robot
Merge pull request #70700 from liggitt/automated-cherry-pick-of-#7069…
52ddfdc 
…9-upstream-release-1.12

Automated cherry pick of #70699: Include read access to controllerrevisions for
k8s-ci-robot added a commit that referenced this pull request Dec 3, 2018
@k8s-ci-robot
Merge pull request #70701 from liggitt/automated-cherry-pick-of-#7069…
d905de0 
…9-upstream-release-1.11

Automated cherry pick of #70699: Include read access to controllerrevisions for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@erictune erictune Awaiting requested review from erictune

Assignees

@dims dims

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Built-in user-facing clusterroles (admin, edit, etc.) missing rules for controller revisions
5 participants
@liggitt @k8s-ci-robot @yastij @dims @enj