Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #70699: Include read access to controllerrevisions for #70700

Merged
merged 1 commit into from Nov 28, 2018
Merged

Automated cherry pick of #70699: Include read access to controllerrevisions for #70700

merged 1 commit into from Nov 28, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 6, 2018

Cherry pick of #70699 on release-1.12.

#70699: Include read access to controllerrevisions for

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 6, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 6, 2018

/priority important-soon
/sig cli
/sig auth
/sig apps
/milestone v1.12

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 6, 2018
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2018
@feiskyer
Copy link
Member

feiskyer commented Nov 8, 2018

/retest

@feiskyer
Copy link
Member

feiskyer commented Nov 9, 2018

@liggitt Should this fix be included in the v1.12.3?

@liggitt
Copy link
Member Author

liggitt commented Nov 9, 2018

@liggitt Should this fix be included in the v1.12.3?

The master PR hasn't merged yet, so I would hold it

@liggitt
Copy link
Member Author

liggitt commented Nov 9, 2018

/hold
For master

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 27, 2018

/kind bug
/hold cancel
/assign @feiskyer

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 27, 2018
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 28, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 28, 2018

/assign @soltysh

@dims
Copy link
Member

dims commented Nov 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 28, 2018

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Nov 28, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 52ddfdc into kubernetes:release-1.12 Nov 28, 2018
@liggitt liggitt deleted the automated-cherry-pick-of-#70699-upstream-release-1.12 branch April 22, 2019 15:16
@liggitt liggitt restored the automated-cherry-pick-of-#70699-upstream-release-1.12 branch April 22, 2019 15:16
@liggitt liggitt deleted the automated-cherry-pick-of-#70699-upstream-release-1.12 branch April 22, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@dims dims

@soltysh soltysh

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @feiskyer @dims @soltysh