New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated kubectl command aliases 'run-container' #70728

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@Pingan2017
Copy link
Member

Pingan2017 commented Nov 7, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
run-container deprecated in v1.7
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove deprecated kubectl command aliases 'run-container'
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 7, 2018

Hi @Pingan2017. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Pingan2017

This comment has been minimized.

Copy link
Member

Pingan2017 commented Nov 7, 2018

/assign @smarterclayton

@Pingan2017 Pingan2017 changed the title Remove deprecated kubectl command aliases 'kubectl run-container' Remove deprecated kubectl command aliases 'run-container' Nov 7, 2018

@Pingan2017

This comment has been minimized.

Copy link
Member

Pingan2017 commented Nov 8, 2018

/cc @soltysh

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Nov 9, 2018

/ok-to-test
/priority cleanup
/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 9, 2018

@soltysh

soltysh approved these changes Nov 9, 2018

Copy link
Contributor

soltysh left a comment

/lgtm
/approve

@Pingan2017 please update the release not, you're making a user visible change that deserves being mentioned

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Pingan2017, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Nov 9, 2018

Manually adding approved label, since this is touching kubectl-related docs.

@Pingan2017

This comment has been minimized.

Copy link
Member

Pingan2017 commented Nov 16, 2018

@soltysh Could you help to add a priority label? Thanks!

@Pingan2017

This comment has been minimized.

Copy link
Member

Pingan2017 commented Nov 16, 2018

/priority important-soon

@Pingan2017

This comment has been minimized.

Copy link
Member

Pingan2017 commented Nov 16, 2018

I can add it by myself. 😅

@Pingan2017

This comment has been minimized.

Copy link
Member

Pingan2017 commented Nov 16, 2018

/test pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot merged commit 1cdc918 into kubernetes:master Nov 16, 2018

18 checks passed

cla/linuxfoundation Pingan2017 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@Pingan2017 Pingan2017 deleted the Pingan2017:remove-kubectl-run-container branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment