Cherry pick stabilizing HPA e2e tests to 1.11 #70736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
jbartosik
force-pushed
the
e2e-stabilization-1-11
branch
3 times, most recently
from
ea8570c
to
2bffa86
Compare
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
jbartosik
force-pushed
the
e2e-stabilization-1-11
branch
from
2bffa86
to
ad88771
Compare
Changes: - Relax stabilization requirement. Size may increase by 1 during stabilization. This is because HPA now stabilizes on max recommendation in the stabilization window. So if it sees a higher sample it should scale up. Resource consumer is imperfect and generates higher samples sometimes. - Lower CPU load generated during stabilization period. This reduces risk of generating samples much higher than expected. - Log status of HPA for easier debugging if the test fails. - Increase expected number of millicores used to handle request to generate usage (see 7d2f3a0). - Change int32 fields that were always cast to int before use to int. - Update boilerplate.
jbartosik
force-pushed
the
e2e-stabilization-1-11
branch
from
ad88771
to
a0cc3b6
Compare
|
Issue #70655 |
|
/assign @MaciekPytel |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @janetkuo |
|
/lgtm |
|
/lgtm |
|
@foxish 1.11 patch manager for CP request. This CP into 1.11 is critical to get a clean CI Signal for 1.13 |
foxish
added
the
cherry-pick-approved
foxish
removed
the
do-not-merge/cherry-pick-not-approved
foxish
added
sig/testing
k8s-ci-robot
removed
the
needs-priority
foxish
added
the
approved
|
Done, approved. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jbartosik, MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it: HPA e2e tests are failing in 1.11. I fixed them on HEAD but they're failing in 1.11.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Issue #69444
Special notes for your reviewer:
Does this PR introduce a user-facing change?: