Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenRequestProjections should allow API server to default empty audience #71007

Merged
merged 1 commit into from
Nov 14, 2018
Merged

TokenRequestProjections should allow API server to default empty audience #71007

merged 1 commit into from
Nov 14, 2018

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Nov 13, 2018 •
edited

/kind bug
/sig auth

Correctly default Audience in the kubelet for TokenRequestProjections.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Nov 13, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2018
@mikedanese mikedanese added this to the v1.13 milestone Nov 13, 2018
@mikedanese mikedanese added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 13, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 13, 2018
@cjcullen
Copy link
Member

/lgtm

For my curiousity, what breaks with {""} compared to {}?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@mikedanese
Copy link
Member Author

@cjcullen Audiences is defaulted in TokenRequest if it's empty. This results in tokens with "aud":[""]

@mikedanese
Copy link
Member Author

/retest

@mikedanese
Copy link
Member Author

For approval:

/assign @jsafrane @saad-ali

@liggitt
Copy link
Member

liggitt commented Nov 14, 2018

lgtm, but should there be a test around this?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2018
@mikedanese
Copy link
Member Author

@liggitt added tests of the defaulting.

@liggitt
Copy link
Member

liggitt commented Nov 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@liggitt
Copy link
Member

liggitt commented Nov 14, 2018

/retest

@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5a84dff into kubernetes:master Nov 14, 2018
@mikedanese mikedanese deleted the allowdefault branch November 14, 2018 20:01
@liggitt
Copy link
Member

liggitt commented Nov 26, 2018

does this need cherry-picking to old releases?

@mikedanese mikedanese mentioned this pull request Nov 26, 2018
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 28, 2018
@k8s-ci-robot
Merge pull request #71432 from mikedanese/automated-cherry-pick-of-#7…
bcc3642 
…1007-upstream-release-1.12

Automated cherry pick of #71007 into upstream release 1.12
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@liggitt liggitt

@awly awly

@jsafrane jsafrane

@cjcullen cjcullen

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mikedanese @cjcullen @liggitt @k8s-ci-robot @saad-ali @awly @jsafrane