Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #71007 into upstream release 1.12 #71432

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Automated cherry pick of #71007 into upstream release 1.12 #71432

merged 1 commit into from
Nov 28, 2018

Conversation

mikedanese
Copy link
Member

Automated cherry pick of #71007 upstream release 1.12

/kind bug
/sig auth

Correctly default Audience in the kubelet for TokenRequestProjections.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Nov 26, 2018
@liggitt
Copy link
Member

liggitt commented Nov 26, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@liggitt
Copy link
Member

liggitt commented Nov 26, 2018

/assign @saad-ali
(original PR approver)

@mikedanese mikedanese force-pushed the automated-cherry-pick-of-#71007-upstream-release-1.12 branch from 6377fc7 to eac3227 Compare November 27, 2018 19:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018
@mikedanese
Copy link
Member Author

mikedanese commented Nov 27, 2018 •
edited
Loading

Fixed a gofmt difference between go 1.10 and go 1.11 to make verify happy.

https://github.com/kubernetes/kubernetes/compare/6377fc7a9e0efd6b6319540f594578be14f3298e..eac322757b55d39584bda875c428935141f2a064

@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018
@mikedanese mikedanese added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018
@mikedanese
Copy link
Member Author

Assign patch manager:

/assign @feiskyer

@feiskyer
Copy link
Member

@mikedanese Could you add a release note in the original PR? Thanks

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit bcc3642 into kubernetes:release-1.12 Nov 28, 2018
@mikedanese mikedanese deleted the automated-cherry-pick-of-#71007-upstream-release-1.12 branch November 28, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@msau42 msau42 Awaiting requested review from msau42

Assignees

@feiskyer feiskyer

@liggitt liggitt

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikedanese @liggitt @saad-ali @k8s-ci-robot @feiskyer