Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.13.1] Automated cherry pick of #71601: Surface help for insecure ports to explain how to disable #71602

Merged
merged 1 commit into from
Dec 10, 2018
Merged

[1.13.1] Automated cherry pick of #71601: Surface help for insecure ports to explain how to disable #71602

merged 1 commit into from
Dec 10, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 30, 2018

Cherry pick of #71601 on release-1.13.

#71601: Surface help for insecure ports to explain how to disable

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 30, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 30, 2018

/assign @sttts
/assign @tpepper
/milestone v1.13
/priority important-soon

not release blocking, targeting 1.13.1 is fine

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 30, 2018
@liggitt liggitt changed the title Automated cherry pick of #71601: Surface help for insecure ports to explain how to disable [1.13.1] Automated cherry pick of #71601: Surface help for insecure ports to explain how to disable Nov 30, 2018
@liggitt
Copy link
Member Author

liggitt commented Nov 30, 2018

/retest

@aleksandra-malinowska aleksandra-malinowska added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 7, 2018
@liggitt liggitt force-pushed the automated-cherry-pick-of-#71601-upstream-release-1.13 branch from fa4323a to 9c02a66 Compare December 7, 2018 13:58
@sttts
Copy link
Contributor

sttts commented Dec 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
@liggitt
Copy link
Member Author

liggitt commented Dec 10, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 10, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 39dd1f8 into kubernetes:release-1.13 Dec 10, 2018
@liggitt liggitt deleted the automated-cherry-pick-of-#71601-upstream-release-1.13 branch April 22, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@sttts sttts

@tpepper tpepper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @k8s-ci-robot @sttts @fejta-bot @tpepper @aleksandra-malinowska