Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0 #71721

Merged
merged 1 commit into from Dec 10, 2018
Merged

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0 #71721

merged 1 commit into from Dec 10, 2018

Conversation

wangzhen127
Copy link
Member

Cherry pick of #71522 on release-1.10.

#71522: Use Node-Problem-Detector v0.6.0

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2018
@wangzhen127
Copy link
Member Author

/assign @yguo0905
/kind feature
/sig node
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 4, 2018
@wangzhen127
Copy link
Member Author

/assign @Random-Liu

@wangzhen127
Copy link
Member Author

/retest

@yguo0905
Copy link
Contributor

yguo0905 commented Dec 5, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2018
@Random-Liu
Copy link
Member

/lgtm

@wangzhen127
Copy link
Member Author

/assign @vishh

vishh
vishh reviewed Dec 6, 2018
View reviewed changes
cluster/gce/gci/configure-helper.sh
@@ -1032,6 +1032,11 @@ EOF
}

function create-node-problem-detector-kubeconfig {
local apiserver_address="${1}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this logic being introduced? Can you add some relevant comments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to fix kubernetes/node-problem-detector#227. This is consistent with create-kubelet-kubeconfig. I think it is the correct and standard way now, so I didn't add any comment.

@vishh
Copy link
Contributor

vishh commented Dec 6, 2018

Kindly resolve the need code comments nit prior to submitting.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vishh, wangzhen127, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2018
@wangzhen127
Copy link
Member Author

Kindly resolve the need code comments nit prior to submitting.

@vishh, I replied the comment. Let me know if you still think the comment is needed.

@wangzhen127
Copy link
Member Author

Patcher manager, PTAL
/assign @MaciekPytel

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit 23cfd41 into kubernetes:release-1.10 Dec 10, 2018
@wangzhen127 wangzhen127 deleted the automated-cherry-pick-of-#71522-upstream-release-1.10 branch December 10, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishh vishh vishh left review comments

@bowei bowei Awaiting requested review from bowei

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@Random-Liu Random-Liu

@vishh vishh

@MaciekPytel MaciekPytel

@yguo0905 yguo0905

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wangzhen127 @yguo0905 @Random-Liu @vishh @k8s-ci-robot @MaciekPytel