Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-go: extract new keyutil package from util/cert #71896

Merged
merged 1 commit into from Feb 23, 2019
Merged

client-go: extract new keyutil package from util/cert #71896

merged 1 commit into from Feb 23, 2019

Conversation

awly
Copy link
Contributor

@awly awly commented Dec 10, 2018

This package contains public/private key utilities copied directly from
client-go/util/cert. All imports were updated.

Future PRs will actually refactor the libraries.

Updates #71004

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 10, 2018
@awly
Copy link
Contributor Author

awly commented Dec 10, 2018 •
edited

/sig auth
/cc @mikedanese @liggitt

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 10, 2018
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubeadm area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 10, 2018
neolit123
neolit123 approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @awly
/approve
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 10, 2018
@krmayankk
Copy link

krmayankk commented Dec 17, 2018 •
edited

@awly @neolit123 is the package name client-go/util/keyutil easily discoverable to mean private/public key utilities ?. Should this something like certkeyutil or just certkey or something more specific ? There are some guidelines here as well https://blog.golang.org/package-names

@neolit123
Copy link
Member

@krmayankk
the name SGTM, but let's see if others have comments too.

@awly
Copy link
Contributor Author

awly commented Dec 17, 2018

I plan to end up with client-go/util/keyutil and client-go/util/certutil (or x509util, not sure yet).

Clearly separating the two domains is valuable, otherwise it will turn back into what client-go/util/cert is now - a kitchen sink of anything related to x509/tls and asymmetric keys.

@fedebongio
Copy link
Contributor

/assign @caesarxuchao @mikedanese

caesarxuchao
caesarxuchao reviewed Dec 21, 2018
View reviewed changes
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quibble on the package name, otherwise lgtm.

/approve
I'll leave the lgtm to @mikedanese

staging/src/k8s.io/client-go/util/keyutil/key.go
@@ -0,0 +1,348 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have named the package as "key" instead of "keyutil", just like the "cert" package is not named as "certutil".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is that key has a much higher likelihood of name collision with types/vars.
You can see that https://github.com/kubernetes/kubernetes/search?q=k8s.io%2Fclient-go%2Futil%2Fcert+certutil&unscoped_q=k8s.io%2Fclient-go%2Futil%2Fcert+certutil cert package is frequently aliased to certutil for this reason.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2019
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jan 18, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2019
@mourya007
Copy link

I guess retesting will work
/test pull-kubernetes-local-e2e-containerized

@awly awly force-pushed the client-go-keyutil branch 2 times, most recently from 1580449 to 402d8da Compare January 29, 2019 23:09
@awly
Copy link
Contributor Author

awly commented Feb 1, 2019

Ping @mikedanese @smarterclayton

@mikedanese
Copy link
Member

Thanks!

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2019
@mikedanese
Copy link
Member

For approval.

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2019
Extract new keyutil package from client-go/util/cert
1845839 
This package contains public/private key utilities copied directly from
client-go/util/cert. All imports were updated.

Future PRs will actually refactor the libraries.

Updates kubernetes#71004
@awly
Copy link
Contributor Author

awly commented Feb 19, 2019

Rebased.
Ping @liggitt for approval

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 19, 2019
@neolit123
Copy link
Member

/skip
/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 19, 2019 •
edited

@awly: The following tests failed for commit 1845839, say /retest to rerun them:

Test name Details Rerun command
pull-kubernetes-e2e-kops-aws 402d8da7b0ea76b8e94ec30d985af4d3840bdc3a link
pull-kubernetes-local-e2e-containerized 1845839 link

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member

liggitt commented Feb 23, 2019

/retest
/approve

@liggitt
Copy link
Member

liggitt commented Feb 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awly, caesarxuchao, liggitt, mikedanese, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit b5566c7 into kubernetes:master Feb 23, 2019
@rajathagasthya rajathagasthya mentioned this pull request Nov 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@neolit123 neolit123 neolit123 approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@mikedanese mikedanese

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubeadm area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@awly @krmayankk @neolit123 @fedebongio @mourya007 @mikedanese @k8s-ci-robot @liggitt @caesarxuchao @smarterclayton