Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kubelet log flushing issue in azure disk #71990

Merged
merged 1 commit into from Dec 13, 2018
Merged

fix kubelet log flushing issue in azure disk #71990

merged 1 commit into from Dec 13, 2018

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Dec 12, 2018 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix kubelet log flushing issue in azure disk, There are too many logs in GetVolumeLimits on azure disk, which would flush kubelet logs, it happens every 10 seconds:

Dec 12 08:02:00 k8s-agentpool-36010883-vmss000001 kubelet[4008]: I1212 08:02:00.046830    4008 azure_dd.go:190] got a matching size in getMaxDataDiskCount, Name: Standard_DS2_v2, MaxDataDiskCount: 8
Dec 12 08:02:10 k8s-agentpool-36010883-vmss000001 kubelet[4008]: I1212 08:02:10.062522    4008 azure_dd.go:190] got a matching size in getMaxDataDiskCount, Name: Standard_DS2_v2, MaxDataDiskCount: 8
Dec 12 08:02:20 k8s-agentpool-36010883-vmss000001 kubelet[4008]: I1212 08:02:20.075571    4008 azure_dd.go:190] got a matching size in getMaxDataDiskCount, Name: Standard_DS2_v2, MaxDataDiskCount: 8
Dec 12 08:02:30 k8s-agentpool-36010883-vmss000001 kubelet[4008]: I1212 08:02:30.089377    4008 azure_dd.go:190] got a matching size in getMaxDataDiskCount, Name: Standard_DS2_v2, MaxDataDiskCount: 8

Which issue(s) this PR fixes:

Fixes #71989

Special notes for your reviewer:
This issue happens only on v1.12, v.13

Does this PR introduce a user-facing change?:

none

Release note:

fix kubelet log flushing issue in azure disk

/kind bug
/assign @feiskyer
/priority important-soon
/sig azure

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 12, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/azure cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 12, 2018
feiskyer
feiskyer reviewed Dec 12, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

This was referenced Dec 13, 2018
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 13, 2018
@k8s-ci-robot
Merge pull request #72010 from andyzhangx/automated-cherry-pick-of-#7…
f49fa02 
…1990-upstream-release-1.12

Automated cherry pick of #71990: fix kubelet log flushing issue in azure disk
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 59fce36 into kubernetes:master Dec 13, 2018
k8s-ci-robot added a commit that referenced this pull request Jan 5, 2019
@k8s-ci-robot
Merge pull request #72009 from andyzhangx/automated-cherry-pick-of-#7…
f2806ab 
…1990-upstream-release-1.13

Automated cherry pick of #71990: fix kubelet log flushing issue in azure disk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@karataliu karataliu Awaiting requested review from karataliu

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

too many logs in GetVolumeLimits on azure disk
4 participants
@andyzhangx @k8s-ci-robot @fejta-bot @feiskyer