New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go1.11.4 #72084

Merged
merged 1 commit into from Dec 19, 2018

Conversation

@ixdy
Copy link
Member

ixdy commented Dec 15, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This is basically a rehash of #72035. It turns out that go1.11.3 introduced some regressions, so we need to update to go1.11.4 instead.

This release includes some fixes besides just the regression fix; full details at https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved.

Which issue(s) this PR fixes:
x-ref #72032

Does this PR introduce a user-facing change?:

Update to use go1.11.4.
@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Dec 15, 2018

/assign @cblecker

It seems like docker hasn't published a golang:1.11.4 image yet, so I can't build the cross-build image yet.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Dec 16, 2018

/priority critical-urgent
/lgtm
/hold

This looks good, but placing hold so @fejta-bot doesn't go nuts retesting this.

Something is stalled out on the docker side for publishing the new tags: docker-library/golang#255

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Dec 18, 2018

docker-library/golang#255 is now fixed and unblocked from the docker side. The image for 1.11.4 is also available on dockerhub: https://hub.docker.com/_/golang/?tab=tags.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Dec 18, 2018

yep, working on the images now.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Dec 18, 2018

/retest

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Dec 18, 2018

/hold cancel

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Dec 19, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6858c95 into kubernetes:master Dec 19, 2018

16 of 19 checks passed

pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation ixdy authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 19, 2018

@ixdy: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 7397a62 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nikhita nikhita referenced this pull request Dec 19, 2018

Closed

Update to go1.11.4 #72032

k8s-ci-robot added a commit that referenced this pull request Dec 29, 2018

Merge pull request #72071 from ixdy/automated-cherry-pick-of-#72035-u…
…pstream-release-1.13

Automated cherry pick of #72035 and #72084: bump golang to 1.11.4 (CVE-2018-16875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment