Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go1.11.4 #72084

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Update to go1.11.4 #72084

merged 1 commit into from
Dec 19, 2018

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Dec 15, 2018

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This is basically a rehash of #72035. It turns out that go1.11.3 introduced some regressions, so we need to update to go1.11.4 instead.

This release includes some fixes besides just the regression fix; full details at https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved.

Which issue(s) this PR fixes:
x-ref #72032

Does this PR introduce a user-facing change?:

Update to use go1.11.4.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 15, 2018
@ixdy
Copy link
Member Author

ixdy commented Dec 15, 2018

/assign @cblecker

It seems like docker hasn't published a golang:1.11.4 image yet, so I can't build the cross-build image yet.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2018
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 15, 2018
@ixdy ixdy mentioned this pull request Dec 15, 2018
Merged
@cblecker
Copy link
Member

/priority critical-urgent
/lgtm
/hold

This looks good, but placing hold so @fejta-bot doesn't go nuts retesting this.

Something is stalled out on the docker side for publishing the new tags: docker-library/golang#255

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 16, 2018
@nikhita nikhita mentioned this pull request Dec 17, 2018
Merged
@nikhita
Copy link
Member

nikhita commented Dec 18, 2018

docker-library/golang#255 is now fixed and unblocked from the docker side. The image for 1.11.4 is also available on dockerhub: https://hub.docker.com/_/golang/?tab=tags.

@ialidzhikov ialidzhikov mentioned this pull request Dec 18, 2018
Merged
@ixdy
Copy link
Member Author

ixdy commented Dec 18, 2018

yep, working on the images now.

@ixdy
Copy link
Member Author

ixdy commented Dec 18, 2018

/retest

@ixdy
Copy link
Member Author

ixdy commented Dec 18, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2018
@ixdy
Copy link
Member Author

ixdy commented Dec 19, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6858c95 into kubernetes:master Dec 19, 2018
@k8s-ci-robot
Copy link
Contributor

@ixdy: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 7397a62 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nikhita nikhita mentioned this pull request Dec 19, 2018
Closed
k8s-ci-robot added a commit that referenced this pull request Dec 29, 2018
@k8s-ci-robot
Merge pull request #72071 from ixdy/automated-cherry-pick-of-#72035-u…
4980e10 
…pstream-release-1.13

Automated cherry pick of #72035 and #72084: bump golang to 1.11.4 (CVE-2018-16875)
@nikhita nikhita mentioned this pull request Jan 4, 2019
Merged
@ixdy ixdy mentioned this pull request Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas Awaiting requested review from luxas

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ixdy @k8s-ci-robot @cblecker @nikhita