kubelet: fixes cadvisor internal error #72340
Conversation
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
area/kubelet
sig/node
|
/retest |
k8s-ci-robot
added
release-note
makocchi-git
changed the title
|
/retest |
|
/assign @yujuhong |
| @@ -42,7 +42,7 @@ func (i *imageFsInfoProvider) ImageFsInfoLabel() (string, error) { | |||
| // This is a temporary workaround to get stats for cri-o from cadvisor | |||
| // and should be removed. | |||
| // Related to https://github.com/kubernetes/kubernetes/issues/51798 | |||
| if i.runtimeEndpoint == CrioSocket { | |||
| if i.runtimeEndpoint == CrioSocket || i.runtimeEndpoint == "unix://"+CrioSocket { | |||
There was a problem hiding this comment.
As per https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/ , the runtimeEndpoint can be both tcp and unix. So with that in mind , is pre-pending unix:// still the right thing to do ?
--container-runtime-endpoint string
-- | [Experimental] The endpoint of remote runtime service. Currently unix socket is supported on Linux, and tcp is supported on windows.
There was a problem hiding this comment.
@krmayankk Thank you for your comment.
As you mentioned, runtimeEndpoint supports both unix(on linux) and tcp(on windows).
I think that this "helpers_linux.go" is used by only linux platform.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
@makocchi-git: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
ping @yujuhong |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: makocchi-git, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
When kubelet is set
--container-runtime-endpoint=unix:///var/run/crio/crio.sock, cadvisor in kubelet returnsInternal Error: failed to get imageFs stats: failed to get imageFs info: no imagefs label for configured runtimebecauseruntimeEndpointis not assumed "unix://" prefix for CrioSocket.Does this PR introduce a user-facing change?: