New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stale OutOfDisk condition from kubelet side #72507

Merged
merged 1 commit into from Jan 19, 2019

Conversation

@dixudx
Copy link
Member

dixudx commented Jan 3, 2019

What type of PR is this?
Remove stale node condition OutOfDisk

What this PR does / why we need it:

Node condition OutOfDisk has been removed starting from v1.13

A 1.12 kubelet upgraded to a 1.13 kubelet leaves the previously reported OutOfDisk condition in place, and it eventually gets switched to Unknown status.

We should cherry pick this to v1.13.

Which issue(s) this PR fixes:

Fixes #72485

Special notes for your reviewer:
/cc liggitt resouer
/cc kubernetes/sig-node-bugs

Does this PR introduce a user-facing change?:

remove stale OutOfDisk condition from kubelet side

Signed-off-by: stephen.xd@alibaba-inc.com

@changyaowei

This comment has been minimized.

Copy link
Contributor

changyaowei commented Jan 3, 2019

LGTM

@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Jan 3, 2019

/retest

@zhangxiaoyu-zidif

This comment has been minimized.

Copy link
Member

zhangxiaoyu-zidif commented Jan 3, 2019

/test pull-kubernetes-local-e2e-containerized

1 similar comment
@zhangxiaoyu-zidif

This comment has been minimized.

Copy link
Member

zhangxiaoyu-zidif commented Jan 3, 2019

/test pull-kubernetes-local-e2e-containerized

Show resolved Hide resolved pkg/kubelet/kubelet_node_status.go Outdated
Show resolved Hide resolved pkg/kubelet/kubelet_node_status.go Outdated

@dixudx dixudx force-pushed the dixudx:remove_stale_OutOfDisk branch from 7f72bac to b0343ef Jan 4, 2019

@resouer
Copy link
Member

resouer left a comment

We do need a test to verify the change @dixudx

@dixudx dixudx force-pushed the dixudx:remove_stale_OutOfDisk branch from b0343ef to e1a854b Jan 6, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jan 6, 2019

@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Jan 7, 2019

Flaky tests here. Will retest it when the CI becomes happy.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 7, 2019

looks good to me structurally

will leave to @kubernetes/sig-node-pr-reviews for lgtm/approval

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Jan 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 7, 2019

@vikaschoudhary16

This comment has been minimized.

Copy link
Member

vikaschoudhary16 commented Jan 8, 2019

/lgtm

@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Jan 9, 2019

/retest

1 similar comment
@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Jan 13, 2019

/retest

@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Jan 18, 2019

ping @kubernetes/sig-node-pr-reviews for approval. Thanks.

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Jan 19, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Jan 19, 2019

/priority important-soon
/kind cleanup

@k8s-ci-robot k8s-ci-robot merged commit cb09d4d into kubernetes:master Jan 19, 2019

19 checks passed

cla/linuxfoundation dixudx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@dixudx dixudx deleted the dixudx:remove_stale_OutOfDisk branch Jan 19, 2019

rfranzke added a commit to gardener/gardener that referenced this pull request Feb 1, 2019

Remove stale OutOfDisk node condition for 1.13 clusters
References:
- gardener/machine-controller-manager#214
- kubernetes/kubernetes#72507

```improvement operator
The shoot care controller does now remove stale `OutOfDisk` node conditions for 1.13 clusters. See kubernetes/kubernetes#72507 for more details.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment