remove stale OutOfDisk condition from kubelet side #72507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/S
dixudx
force-pushed
the
remove_stale_OutOfDisk
branch
from
bcbfb89
to
7f72bac
Compare
|
LGTM |
|
/retest |
|
/test pull-kubernetes-local-e2e-containerized |
1 similar comment
|
/test pull-kubernetes-local-e2e-containerized |
dashpole
reviewed
Jan 3, 2019
dixudx
force-pushed
the
remove_stale_OutOfDisk
branch
from
7f72bac
to
b0343ef
Compare
liggitt
reviewed
Jan 4, 2019
dixudx
force-pushed
the
remove_stale_OutOfDisk
branch
from
b0343ef
to
e1a854b
Compare
k8s-ci-robot
added
size/M
|
Flaky tests here. Will retest it when the CI becomes happy. |
|
looks good to me structurally will leave to @kubernetes/sig-node-pr-reviews for lgtm/approval |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
ping @kubernetes/sig-node-pr-reviews for approval. Thanks. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dixudx, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
Jan 30, 2019
rfranzke
added a commit
to gardener/gardener
that referenced
this pull request
Jan 31, 2019
rfranzke
added a commit
to gardener/gardener
that referenced
this pull request
Feb 1, 2019
References: - gardener/machine-controller-manager#214 - kubernetes/kubernetes#72507 ```improvement operator The shoot care controller does now remove stale `OutOfDisk` node conditions for 1.13 clusters. See kubernetes/kubernetes#72507 for more details. ```
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 23, 2019
…507-upstream-release-1.13 Automated cherry pick of #72507: remove stale OutOfDisk condition from kubelet side
richardyuwen
pushed a commit
to richardyuwen/gardener
that referenced
this pull request
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Remove stale node condition OutOfDisk
What this PR does / why we need it:
Node condition OutOfDisk has been removed starting from v1.13
A 1.12 kubelet upgraded to a 1.13 kubelet leaves the previously reported OutOfDisk condition in place, and it eventually gets switched to Unknown status.
We should cherry pick this to v1.13.
Which issue(s) this PR fixes:
Fixes #72485
Special notes for your reviewer:
/cc liggitt resouer
/cc kubernetes/sig-node-bugs
Does this PR introduce a user-facing change?:
Signed-off-by: stephen.xd@alibaba-inc.com