-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Separates DNS hosts entries test #72729
tests: Separates DNS hosts entries test #72729
Conversation
Hi @BCLAU. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @bgrant0607 @danwinship |
/ok-test-test |
/ok-to-test |
/test pull-kubernetes-e2e-gce |
/sig network |
@kubernetes/sig-network-pr-reviews @thockin @dcbw @caseydavenport Can the sig-network please sign off on this conformance related change? |
/milestone v1.14 |
/approve |
Looks like someone from conformance needs to do the final approval. |
Changes to the set of conformance tests should have release notes. Please add one that briefly explains what this change is to someone who cares about what conformance tests are run, passing/failing, etc., such as a Kubernetes provider or someone building their own cluster "the hard way". That should be added to our release-note guidance: |
@bowei The GCE/GKE-specific tests of google.com and metadata shouldn't be in the conformance test. Please move it to a non-conformance e2e test. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bclau, bgrant0607, bowei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI, I filed an issue proposing that any conformance test that checks the provider should die and fail: #74432 |
/hold |
The hold can be removed once a release note is written |
I've added a Release Note, but I'm not particularly sure about its formatting, if I should break the lines or not. |
@prameshj can you take a look at moving the GCE-specific tests out of the conformance? |
In the PR description, the release note should go in the stanza under "Does this PR introduce a user-facing change?" where it currently says "NONE". |
Strange. For some reason, it didn't save my edit. Luckily, the message was still there when I tried to edit it again. |
/lgtm |
At the moment, Windows cannot mount individual files into Containers, which means
that the Kubelet-managed hosts file cannot be mounted into the Container, causing
the "should provide DNS for the cluster" test to fail.
This test separates the hosts entries checks from the mentioned test to a new test.
What type of PR is this?
/kind failing-test
/kind feature
/sig testing
/sig windows
What this PR does / why we need it:
Which issue(s) this PR fixes:
At the moment, mounting individual files in Docker Containers on Windows is not possible, and because of this, Kubelet cannot mount and manage the Containers'
hosts
files.Because of this, the test
should provide DNS for the cluster
will fail when using Windows Containers because thehosts
entries cannot be validated.This patch splits the
/etc/hosts
file entries validation into a separate test, which is a necessary step in order to have the mentioned test pass on Windows.Related issue: #70189
Special notes for your reviewer:
Does this PR introduce a user-facing change?: